8000 [SDK] Fix memory leak in TlsRandomNumberGenerator() constructor by hongweipeng · Pull Request #2661 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[SDK] Fix memory leak in TlsRandomNumberGenerator() constructor #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 19, 2024
Merged

[SDK] Fix memory leak in TlsRandomNumberGenerator() constructor #2661

merged 2 commits into from
Jul 19, 2024

Conversation

hongweipeng
Copy link
Contributor
@hongweipeng hongweipeng commented May 7, 2024 •
edited
8000 Loading

Fixes #2660

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@hongweipeng hongweipeng requested a review from a team May 7, 2024 07:26
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented May 7, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hongweipeng / name: Weipeng Hong (6b44492)
  • ✅ login: marcalff / name: Marc Alff (1f404a3)

@marcalff marcalff added the pr:waiting-on-cla Waiting on CLA label May 7, 2024
@hongweipeng hongweipeng force-pushed the fix-random-memory-leak branch from e6b5f8b to c2ce0fb Compare May 7, 2024 08:29
@marcalff marcalff removed the pr:waiting-on-cla Waiting on CLA label May 7, 2024
@hongweipeng hongweipeng force-pushed the fix-random-memory-leak branch 3 times, most recently from cdffe88 to 9ebc698 May 8, 2024 04:02
ThomsonTan
ThomsonTan reviewed May 8, 2024
View reviewed changes
@hongweipeng hongweipeng force-pushed the fix-random-memory-leak branch from 9ebc698 to e665d74 Compare May 8, 2024 06:59
@hongweipeng hongweipeng force-pushed the fix-random-memory-leak branch from be00d4d to 6b44492 Compare May 19, 2024 10:20
owent
owent approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member
@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff marcalff changed the title Fix memory leak in TlsRandomNumberGenerator() constructor #2660 [SDK] Fix memory leak in TlsRandomNumberGenerator() constructor #2660 Jul 19, 2024
@marcalff marcalff changed the title [SDK] Fix memory leak in TlsRandomNumberGenerator() constructor #2660 [SDK] Fix memory leak in TlsRandomNumberGenerator() constructor Jul 19, 2024
@codecov Codecov
Copy link
codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (497eaf4) to head (1f404a3).
Report is 108 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2661      +/-   ##
==========================================
+ Coverage   87.12%   87.60%   +0.49%     
==========================================
  Files         200      190      -10     
  Lines        6109     5870     -239     
==========================================
- Hits         5322     5142     -180     
+ Misses        787      728      -59
Files Coverage Δ
sdk/src/common/random.cc 96.00% <100.00%> (+0.17%) ⬆️

... and 121 files with indirect coverage changes

@marcalff marcalff merged commit deed1e3 into open-telemetry:main Jul 19, 2024
@BrewTestBot BrewTestBot mentioned this pull request Oct 8, 2024
Merged
@hongweipeng hongweipeng deleted the fix-random-memory-leak branch November 20, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomsonTan ThomsonTan ThomsonTan left review comments

@owent owent owent approved these changes

Assignees

@ThomsonTan ThomsonTan

@lalitb lalitb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TlsRandomNumberGenerator() can cause memory leaks

5 participants

@hongweipeng @ThomsonTan @owent @lalitb @marcalff
0