8000 [CI] Benchmark, provide units with --benchmark_min_time by marcalff · Pull Request #2621 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[CI] Benchmark, provide units with --benchmark_min_time #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2024
Merged

[CI] Benchmark, provide units with --benchmark_min_time #2621

merged 2 commits into from
Apr 3, 2024

Conversation

marcalff
Copy link
Member

Fixes #2620

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team March 28, 2024 21:23
@ThomsonTan
Copy link
Contributor

Does this issue reach otel-cpp after the recent upgrade?

@marcalff
Copy link
Member Author

Does this issue reach otel-cpp after the recent upgrade?

PR #2597 upgraded from benchmark 1.7.1 to 1.8.3, and the issue started at that point.

@marcalff
Copy link
Member Author

Note that this PR is tentative:

  • benchmark is not executed in CI for each PR, only in the main branch
  • We will see after the merge to main if the CI is fixed or not, and if not, at least we will be able to inspect logs.

@marcalff marcalff merged commit 13a4c45 into open-telemetry:main Apr 3, 2024
@BrewTestBot BrewTestBot mentioned this pull request Apr 21, 2024
Closed
@marcalff marcalff deleted the fix_benchmark_ci_2620 branch June 3, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Benchmark run is broken in CI
3 participants
@marcalff @ThomsonTan @lalitb
0