8000 [bazel] Move -std=c++14 to .bazelrc by keith · Pull Request #2600 · open-telemetry/opentelemetry-cpp · GitHub
[go: up one dir, main page]
Skip to content

[bazel] Move -std=c++14 to .bazelrc #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2024
Merged

[bazel] Move -std=c++14 to .bazelrc #2600

merged 1 commit into from
Mar 21, 2024

Conversation

keith
Copy link
Contributor
@keith keith commented Mar 21, 2024

This way it applies to local builds as well as CI builds

Related: #2599 (comment)

@keith keith requested a review from a team March 21, 2024 18:23
@keith keith mentioned this pull request Mar 21, 2024
Merged
3 tasks
@keith
[bazel] Move -std=c++14 to .bazelrc
262f2c7 
This way it applies to local builds as well as CI builds
marcalff
marcalff approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member
@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@marcalff marcalff merged commit 3f8d954 into open-telemetry:main Mar 21, 2024
@keith keith deleted the ks/cpp-std branch March 21, 2024 19:38
@keith
Copy link
Contributor Author
keith commented Mar 21, 2024

thanks!

@marcalff
Copy link
Member

This now causes the folloging message in build logs, for bazel windows:

cl : Command line warning D9002 : ignoring unknown option '-std=c++14'

marcalff added a commit that referenced this pull request Mar 21, 2024
@marcalff
Revert "[bazel] Move -std=c++14 to .bazelrc (#2600)"
0d3c3a3 
This reverts commit 3f8d954.
@keith keith mentioned this pull request Mar 21, 2024
Merged
@keith
Copy link
Contributor Author
keith commented Mar 21, 2024

oops, thanks! #2601

@marcalff marcalff mentioned this pull request Mar 21, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Apr 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcalff marcalff marcalff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keith @marcalff
0