10BC0 [chore][processor/groupbytrace, internal/otelarrow] More testify related fixes by mx-psi · Pull Request #42516 · open-telemetry/opentelemetry-collector-contrib · GitHub
[go: up one dir, main page]
Skip to content

[chore][processor/groupbytrace, internal/otelarrow] More testify related fixes #42516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

[chore][processor/groupbytrace, internal/otelarrow] More testify related fixes #42516

merged 1 commit into from
Sep 5, 2025

Conversation

mx-psi
Copy link
Member
@mx-psi mx-psi commented 8000 Sep 5, 2025 •
edited
Loading

Description

Updates #42458 to adapt to stretchr/testify#1427

Link to tracking issue

Fixes #42486
Fixes #42411

Testing

Ran each test 100 times locally and made sure it passed

This was referenced Sep 5, 2025
Open
Open
@mx-psi mx-psi marked this pull request as ready for review September 5, 2025 10:14
@mx-psi mx-psi requested a review from a team as a code owner September 5, 2025 10:14
@mx-psi mx-psi requested a review from fatsheep9146 September 5, 2025 10:14
@mx-psi mx-psi mentioned this pull request Sep 5, 2025
Closed
@mx-psi mx-psi merged commit f004a36 into open-telemetry:main Sep 5, 2025
191 of 192 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@iblancasa iblancasa Awaiting requested review from iblancasa

@jmacd jmacd Awaiting requested review from jmacd

@moh-osman3 moh-osman3 Awaiting requested review from moh-osman3

Assignees

@andrzej-stencel andrzej-stencel

Labels
internal/otelarrow processor/groupbytrace Group By Trace processor
Projects
None yet
Milestone
v0.135.0
Development

Successfully merging this pull request may close these issues.

[internal/otelarrow/admission2]: Report for failed tests on main [internal/otelarrow/admission2]: Report for failed tests on main
3 participants
@mx-psi @axw @andrzej-stencel
0