8000 chore: use JDK 8 in ci by toddbaert · Pull Request #127 · open-feature/java-sdk-contrib · GitHub
[go: up one dir, main page]

Skip to content

chore: use JDK 8 in ci #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
- name: Checkout Repository
uses: actions/checkout@v3

- name: Set up JDK 18
- name: Set up JDK 8
uses: actions/setup-java@v3
with:
java-version: "18"
distribution: "temurin"
java-version: '8'
distribution: 'temurin'
cache: maven

- name: Cache local Maven repository
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ jobs:
if: ${{ steps.release.outputs.releases_created }}
uses: actions/checkout@v3

- name: Set up JDK 18
- name: Set up JDK 8
if: ${{ steps.release.outputs.releases_created }}
uses: actions/setup-java@v3
with:
java-version: "18"
distribution: "temurin"
java-version: '8'
distribution: 'temurin'
cache: maven
server-id: ossrh
server-username: OSSRH_USERNAME
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## System Requirements

Java 18 is recommended for the tooling, plugins, etc. Maven 3.8+ is recommended.
Java 8+ is required for the tooling, plugins, etc. Maven 3.8+ is recommended.

## Compilation target(s)

Expand Down
Loading
0