Fix some undefined behaviour in some maintainer mode code (arangodb#14891)

neunhoef · web-flow · commit b4920a82f01a · 2021-11-09T19:09:16.000+01:00
diff --git a/arangod/Agency/AsyncAgencyComm.cpp b/arangod/Agency/AsyncAgencyComm.cpp
@@ -491,10 +491,10 @@ void AsyncAgencyCommManager::reportError(std::string const& endpoint) {
       << "reportError(" << endpoint << "), endpoints = " << _endpoints;
   if (endpoint == _endpoints.front()) {
     _endpoints.pop_front();
+    _endpoints.push_back(endpoint);
     LOG_TOPIC("aac43", DEBUG, Logger::AGENCYCOMM)
         << "Error using endpoint " << endpoint << ", switching to "
         << _endpoints.front();
-    _endpoints.push_back(endpoint);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -491,10 +491,10 @@ void AsyncAgencyCommManager::reportError(std::string const& endpoint) {`
`491`	`491`	`<< "reportError(" << endpoint << "), endpoints = " << _endpoints;`
`492`	`492`	`if (endpoint == _endpoints.front()) {`
`493`	`493`	`_endpoints.pop_front();`
	`494`	`+ _endpoints.push_back(endpoint);`
`494`	`495`	`LOG_TOPIC("aac43", DEBUG, Logger::AGENCYCOMM)`
`495`	`496`	`<< "Error using endpoint " << endpoint << ", switching to "`
`496`	`497`	`<< _endpoints.front();`
`497`		`- _endpoints.push_back(endpoint);`
`498`	`498`	`}`
`499`	`499`	`}`
`500`	`500`