8000 Implement umfPool[Set/Get]Tag by igchor · Pull Request #962 · oneapi-src/unified-memory-framework · GitHub
[go: up one dir, main page]
Skip to content

Implement umfPool[Set/Get]Tag #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2024
Merged

Implement umfPool[Set/Get]Tag #962

merged 1 commit into from
Dec 6, 2024

Conversation

igchor
Copy link
Member
@igchor igchor commented Dec 4, 2024 •
edited by ldorau
Loading

Implements #687

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@igchor igchor requested a review from a team as a code owner December 4, 2024 21:55
@bratpiorka
Copy link
Contributor

@igchor do we need this for 0.10x / 2025.1?

lplewa
lplewa reviewed Dec 5, 2024
View reviewed changes
include/umf/memory_pool.h Outdated
/// @brief Set a custom tag on the memory pool that can be later retrieved using umfPoolGetTag.
/// @param hPool specified memory pool
/// @param tag tag to be set
/// @param oldTag [out] previous tag set on the memory pool
Copy link
Contributor
@lplewa lplewa Dec 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document that it's optional and can be null

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@igchor
Copy link
Member Author
igchor commented Dec 5, 2024

@igchor do we need this for 0.10x / 2025.1?

No, for now I only want to use it for v2 L0 adapter which will not be released as part of 2025.1

lukaszstolarczuk
lukaszstolarczuk reviewed Dec 5, 2024
View reviewed changes
@lukaszstolarczuk lukaszstolarczuk merged commit 9bf1316 into oneapi-src:main Dec 6, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lplewa lplewa lplewa left review comments

@vinser52 vinser52 vinser52 approved these changes

@ldorau ldorau ldorau approved these changes

@bratpiorka bratpiorka bratpiorka approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@igchor @bratpiorka @vinser52 @ldorau @lplewa @lukaszstolarczuk
0