8000 Remove the Coarse provider by ldorau · Pull Request #934 · oneapi-src/unified-memory-framework · GitHub
[go: up one dir, main page]
Skip to content
8000

Remove the Coarse provider #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2024
Merged

Remove the Coarse provider #934

merged 3 commits into from
Dec 6, 2024

Conversation

ldorau
Copy link
Contributor
@ldorau ldorau commented Nov 26, 2024 •
edited
Loading

Description

Remove the Coarse provider.

Fixes: #900

Requires:

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau force-pushed the Remove_Coarse_provider branch 4 times, most recently from 6a967a3 to c29e894 Compare December 2, 2024 07:46
@ldorau ldorau changed the title [DRAFT] Remove the Coarse provider Remove the Coarse provider Dec 2, 2024
@ldorau ldorau force-pushed the Remove_Coarse_provider branch 2 times, most recently from 908c9c2 to 61d39a8 Compare December 5, 2024 10:21
@ldorau ldorau marked this pull request as ready for review December 5, 2024 10:22
@ldorau ldorau requested a review from a team as a code owner December 5, 2024 10:22
KFilipek
KFilipek reviewed Dec 5, 2024
View reviewed changes
KFilipek
KFilipek reviewed Dec 5, 2024
View reviewed changes
@ldorau ldorau force-pushed the Remove_Coarse_provider branch from 61d39a8 to fafd163 Compare December 5, 2024 11:00
@ldorau ldorau requested a review from KFilipek December 5, 2024 11:01
KFilipek
KFilipek approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor
@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldorau added 3 commits December 5, 2024 15:54
@ldorau
Remove the Coarse provider
c6749f2 
Fixes: oneapi-src#900

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau
Replace all NULL with nullptr in disjointCoarseMallocPool.cpp
450c5a9 
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau
Rename disjointCoarseMallocPool test to disjointPoolFileProv
7fec989 
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau ldorau force-pushed the Remove_Coarse_provider branch from fafd163 to 7fec989 Compare December 5, 2024 14:55
@ldorau
Copy link
Contributor Author
ldorau commented Dec 5, 2024

Rebased because of a merge conflict.

@ldorau
Copy link
Contributor Author
ldorau commented Dec 6, 2024

@bratpiorka @vinser52 please review

bratpiorka
bratpiorka approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor
@bratpiorka bratpiorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldorau
Copy link
Contributor Author
ldorau commented Dec 6, 2024

Lines: +400 / −3136 :-)

@ldorau ldorau merged commit 04fdd74 into oneapi-src:main Dec 6, 2024
77 checks passed
@ldorau ldorau deleted the Remove_Coarse_provider branch December 6, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KFilipek KFilipek KFilipek approved these changes

@bratpiorka bratpiorka bratpiorka approved these changes

@vinser52 vinser52 Awaiting requested review from vinser52

@lukaszstolarczuk lukaszstolarczuk Awaiting requested review from lukaszstolarczuk

@lplewa lplewa Awaiting requested review from lplewa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IPC API is not implemented in the Coarse provider
3 participants
@ldorau @KFilipek @bratpiorka
0