8000 Fix hwloc patch application on windows by npmiller · Pull Request #710 · oneapi-src/unified-memory-framework · GitHub
[go: up one dir, main page]
Skip to content
< 8000 div class="d-flex flex-column flex-md-row flex-items-start flex-md-items-center">

Fix hwloc patch application on windows #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix hwloc patch application on windows #710

merged 1 commit into from
Sep 9, 2024

Conversation

npmiller
Copy link
Contributor
@npmiller npmiller commented Sep 6, 2024 •
edited
Loading

Description

Windows cmd.exe doesn't have a true command which causes the DPC++ build to fail, (exit 0) will do the same thing but it will work on both linux and windows.

This issue only shows up on Windows and not on a first build, since when building the first time the patch applies cleanly so the || branch is not taken, but then when rebuilding the patch doens't apply and the command errors out in the || branch.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@npmiller
Fix hwloc patch application on windows
674f4e2 
Windows `cmd.exe` doesn't have a `true` command, `(exit 0)` will do the
same thing but it will work on both linux and windows.

This issue only shows up on Windows and not on a first build, since when
building the first time the patch applies cleanly so the `||` branch is
not taken, but then when rebuilding the patch doens't apply and the
command errors out in the `||` branch.
@npmiller npmiller requested a review from a team as a code owner September 6, 2024 09:00
@bratpiorka
Copy link
Contributor

@npmiller thanks for finding and fixing this!

@bratpiorka bratpiorka merged commit e09715a into oneapi-src:main Sep 9, 2024
66 checks passed
@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldorau ldorau ldorau approved these changes

@bratpiorka bratpiorka bratpiorka approved these changes

@lukaszstolarczuk lukaszstolarczuk Awaiting requested review from lukaszstolarczuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@npmiller @bratpiorka @ldorau @lukaszstolarczuk
0