commits for 0.9x rc2 #652
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
commits for 0.9x rc2 #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It add utils_annotate_memory_defined() (which does unpoison on memory region) after all mmap(). This should be unnecessary change but pairs of mmap/munmap do not reset asan's user-poisoning flags, leading to invalid error reports. This bug is describe here - 81619: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81619
Fix the warnings: umf\build\src\libumf.rc(12): warning RC4005: 'UMF_VERSION' : redefinition umf\build\src\proxy_lib\proxy_lib.rc(12): warning RC4005: 'UMF_VERSION' : redefinition Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Add lock for updating file size in OS memory provider, because umfMemoryProviderAlloc() has to be MT-safe. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
use full path, to omit potential conflicts in names with other modules, e.g. in other projects, which can use the same module name.
ASan throws an error whenever the memory poison is called for the memory allocated on GPU: "AddressSanitizer: CHECK failed: asan_mapping.h:359 "((AddrIsInMem(p))) != (0)" (0x0, 0x0)". This commit disables poisoning.
The poison memory macro definition is always defined, so an #ifdef check is insufficient.
Co-authored-by: Krzysztof Filipek <krzysztof.filipek@intel.com>
0c5e2f4 to
7227fb9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
to fix: "ld.lld: error: version script assignment of 'UMF_1.0' to symbol 'umfLevelZeroMemoryProviderOps' failed: symbol not defined" when using lld linker
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
7227fb9 to
19a5bf5
Compare
ldorau
approved these changes
Jul 30, 2024
PatKamin
approved these changes
Jul 30, 2024
lukaszstolarczuk
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commits for 0.9x rc2