10000 add pool alloc counter ctl by lplewa · Pull Request #1361 · oneapi-src/unified-memory-framework · GitHub
[go: up one dir, main page]
Skip to content

add pool alloc counter ctl #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add pool alloc counter ctl #1361

wants to merge 1 commit into from
+207 −9

Conversation

lplewa
Copy link
Contributor
@lplewa lplewa commented Jun 9, 2025

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

@lplewa lplewa force-pushed the piwo branch 3 times, most recently from f5cd152 to 9ddd0d6 Compare June 9, 2025 11:04
bratpiorka
bratpiorka reviewed Jun 9, 2025
View reviewed changes
test/poolFixtures.hpp Outdated
}

for (size_t i = 0; i < num_allocs; i++) {
void *ptr = umfPoolAlignedMalloc(pool_get, size, 4096);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not supported on windows + use utils_get_page_size() (see umfPoolAlignedMalloc test)

@bratpiorka
Copy link
Contributor

LGTM but formatting could be improved (empty lines, comments)

@lplewa lplewa force-pushed the piwo branch 2 times, most recently from 7373f2f to 2c34692 Compare June 9, 2025 14:29
KFilipek
KFilipek requested changes Jun 9, 2025
View reviewed changes
@lplewa lplewa force-pushed the piwo branch 3 times, most recently from 5aa5b38 to 14a7779 Compare June 9, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka bratpiorka left review comments

@KFilipek KFilipek KFilipek requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lplewa @bratpiorka @KFilipek
0