8000 implement malloc_usable_size and enable pool tests for disjoint by pbalcer · Pull Request #1132 · oneapi-src/unified-memory-framework · GitHub
[go: up one dir, main page]
Skip to content

implement malloc_usable_size and enable pool tests for disjoint #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

implement malloc_usable_size and enable pool tests for disjoint #1132

merged 1 commit into from
Feb 26, 2025

Conversation

pbalcer
Copy link
Contributor
@pbalcer pbalcer commented Feb 24, 2025 •
edited
Loading

Description

Implement malloc_usable_size and enable pool tests for disjoint.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • New tests added, especially if they will fail without my changes

@pbalcer pbalcer requested a review from a team as a code owner February 24, 2025 14:14
vinser52
vinser52 reviewed Feb 24, 2025
View reviewed changes
src/pool/pool_disjoint.c Outdated
slab_t *slab =
(slab_t *)critnib_find_le(disjoint_pool->known_slabs, (uintptr_t)ptr);
if (slab == NULL || ptr >= slab_get_end(slab)) {
// regular free
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think comment is incorrect because of copy-n-paste

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

bratpiorka
bratpiorka reviewed Feb 24, 2025
View reviewed chang 8000 es
@pbalcer pbalcer force-pushed the malloc-usable-size-disjoint-pool branch from 943545a to 585547e Compare February 24, 2025 14:23
@pbalcer pbalcer force-pushed the malloc-usable-size-disjoint-pool branch 2 times, most recently from 71d089d to 7d5a238 Compare February 24, 2025 14:30
lplewa
lplewa requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor
@lplewa lplewa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests with allocations done with umfPoolAlignedMalloc().

In almost sure that in the case when we used some "usable" memory to align ptr, you must substract it from "bucket size".

@pbalcer pbalcer force-pushed the malloc-usable-size-disjoint-pool branch from 7d5a238 to cbdd3ac Compare February 24, 2025 14:43
@pbalcer
Copy link
Contributor Author
pbalcer commented Feb 24, 2025

Please add tests with allocations done with umfPoolAlignedMalloc().

In almost sure that in the case when we used some "usable" memory to align ptr, you must substract it from "bucket size".

done.

@pbalcer pbalcer force-pushed the malloc-usable-size-disjoint-pool branch 10 times, most recently from 7cc6fdc to c2f9d5d Compare February 25, 2025 13:12
@pbalcer pbalcer force-pushed the malloc-usable-size-disjoint-pool branch 2 times, most recently from f90922b to 249c364 Compare February 25, 2025 14:24
@bratpiorka bratpiorka merged commit 5d67494 into oneapi-src:main Feb 26, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinser52 vinser52 vinser52 left review comments

@bratpiorka bratpiorka bratpiorka approved these changes

@lplewa lplewa lplewa approved these changes

@kswiecicki kswiecicki kswiecicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pbalcer @vinser52 @bratpiorka @lplewa @kswiecicki
0