8000 Do not overwrite ret code in level_zero_shared_memory example by vinser52 · Pull Request #1098 · oneapi-src/unified-memory-framework · GitHub
[go: up one dir, main page]
Skip to content

Do not overwrite ret code in level_zero_shared_memory example #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

Do not overwrite ret code in level_zero_shared_memory example #1098

merged 1 commit into from
Feb 13, 2025

Conversation

vinser52
Copy link
Contributor
@vinser52 vinser52 commented Feb 13, 2025 •
edited
Loading

Description

While working on the #1086 I found that the umf_example_level_zero_shared_memory returns success even the actual flow failed. See the output below:

test 1
    Start 1: umf_example_level_zero_shared_memory

1: Test command: /home/test-user/actions-runner/_work/unified-memory-framework/unified-memory-framework/build/examples-standalone/level_zero_shared_memory/umf_example_level_zero_shared_memory
1: Test timeout computed to be: 10000000
1: [FATAL UMF] utils_open_library: dlopen(libze_loader.so) failed with error: (null)
1: [FATAL UMF] ze_memory_provider_initialize: Loading Level Zero symbols failed
1: Failed to create a memory provider!
1/1 Test #1: umf_example_level_zero_shared_memory ...   Passed    0.06 sec

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@vinser52 vinser52 requested a review from a team as a code owner February 13, 2025 16:00
@igchor igchor merged commit 727a796 into oneapi-src:main Feb 13, 2025
77 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@igchor igchor igchor approved these changes

@lplewa lplewa Awaiting requested review from lplewa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinser52 @bratpiorka @igchor
0