8000 Add backward compatibility workflow and tests (ver 2) by bratpiorka · Pull Request #1087 · oneapi-src/unified-memory-framework · GitHub
[go: up one dir, main page]
Skip to content

Add backward compatibility workflow and tests (ver 2) #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2025
Merged

Add backward compatibility workflow and tests (ver 2) #1087

merged 4 commits into from
Feb 19, 2025

Conversation

bratpiorka
Copy link
Contributor

Add backward compatibility workflow and tests.

Major changes:

  • use UMF_PROVIDER_OPS_VERSION_CURRENT and UMF_POOL_OPS_VERSION_CURRENT for versioning memory provider and pools struct instead of UMF_VERSION_CURRENT that would be used only for versioning the lib
  • do not assert when the user pass an old provider/pool version of ops to umfMemoryProvider/PoolCreate and print a warning instead

fixes #908

@bratpiorka bratpiorka added enhancement New feature or request high priority labels Feb 10, 2025
@bratpiorka bratpiorka added this to the v0.11.x milestone Feb 10, 2025
@bratpiorka bratpiorka mentioned this pull request Feb 10, 2025
Closed
@bratpiorka bratpiorka force-pushed the rrudnick_compat_wflow2 branch 8 times, most recently from 5da473c to 2bff6a8 Compare February 11, 2025 10:00
@bratpiorka bratpiorka modified the milestones: v0.11.x, v0.12.x Feb 11, 2025
@bratpiorka bratpiorka force-pushed the rrudnick_compat_wflow2 branch 5 times, most recently from def2cb9 to 776e84f Compare February 11, 2025 15:08
@bratpiorka bratpiorka marked this pull request as ready for review February 11, 2025 15:34
@bratpiorka bratpiorka requested a review from a team as a code owner February 11, 2025 15:34
@bratpiorka bratpiorka force-pushed the rrudnick_compat_wflow2 branch 6 times, most recently from e41e379 to d7ff064 Compare February 12, 2025 16:00
lukaszstolarczuk
lukaszstolarczuk requested changes Feb 13, 2025
View reviewed changes
@bratpiorka bratpiorka force-pushed the rrudnick_compat_wflow2 branch from d7ff064 to 5987d62 Compare February 13, 2025 14:58
lukaszstolarczuk
lukaszstolarczuk reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor
@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this PR tested on UR/SYCL? BTW, I'd probably wait until tomorrow, when UR is merged to SYCL.

@lukaszstolarczuk
Copy link
Contributor
lukaszstolarczuk commented Feb 18, 2025 •
edited
Loading

@vinser52 , @lplewa can you please take a look at this PR?

@lplewa
Copy link
Contributor
lplewa commented Feb 18, 2025

Was this PR tested on UR/SYCL? BTW, I'd probably wait until tomorrow, when UR is merged to SYCL.

Why do you want to test it on UR? There is no change in this PR that can brake anything.

@bratpiorka bratpiorka force-pushed the rrudnick_compat_wflow2 branch from 5987d62 to 406be0c Compare February 19, 2025 09:14
@bratpiorka
Copy link
Contributor Author

@lukaszstolarczuk intel/llvm run: intel/llvm#17059

@bratpiorka
Copy link
Contributor Author

@lukaszstolarczuk intel/llvm workflow passed

@lukaszstolarczuk lukaszstolarczuk merged commit 36ccc9d into oneapi-src:main Feb 19, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lplewa lplewa lplewa approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

@kswiecicki kswiecicki kswiecicki approved these changes

@vinser52 vinser52 Awaiting requested review from vinser52

@ldorau ldorau Awaiting requested review from ldorau

Assignees
No one assigned
Labels
enhancement New feature or request high priority
Projects
None yet
Milestone
v0.12.x
Development

Successfully merging this pull request may close these issues.

Implement backward compatibility support in UMF
4 participants
@bratpiorka @lukaszstolarczuk @lplewa @kswiecicki
31A7
0