8000 L0 provider: implement min/recommended page size query by igchor · Pull Request #1059 · oneapi-src/unified-memory-framework · GitHub
[go: up one dir, main page]
Skip to content

L0 provider: implement min/recommended page size query #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2025
Merged

L0 provider: implement min/recommended page size query #1059

merged 2 commits into from
Jan 31, 2025

Conversation

igchor
Copy link
Member
@igchor igchor commented Jan 24, 2025

and allow passing device ordinal through params

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@igchor igchor force-pushed the l0_page_query_ordinal branch 2 times, most recently from d2cd047 to 33c79fb Compare January 24, 2025 19:22
@igchor igchor marked this pull request as ready for review January 24, 2025 19:33
@igchor igchor requested a review from a team as a code owner January 24, 2025 19:33
bratpiorka
bratpiorka reviewed Jan 27, 2025
View reviewed changes
bratpiorka
bratpiorka reviewed Jan 27, 2025
View reviewed changes
PatKamin
PatKamin reviewed Jan 27, 2025
View reviewed changes
lplewa
lplewa reviewed Jan 27, 2025
View reviewed changes
vinser52
vinser52 reviewed Jan 27, 2025
View reviewed changes
vinser52
vinser52 reviewed Jan 27, 2025
View reviewed changes
@igchor igchor force-pushed the l0_page_query_ordinal branch 2 times, most recently from 8026420 to 15b0412 Compare January 27, 2025 16:16
vinser52
vinser52 reviewed Jan 27, 2025
View reviewed changes
@igchor igchor force-pushed the l0_page_query_ordinal branch 2 times, most recently from 1ab2b97 to 5f3a615 Compare January 27, 2025 17:11
lukaszstolarczuk
lukaszstolarczuk reviewed Jan 27, 2025
View reviewed changes
lukaszstolarczuk
lukaszstolarczuk reviewed Jan 28, 2025
View reviewed changes
@igchor igchor force-pushed the l0_page_query_ordinal branch 2 times, most recently from 4208f35 to 7709e9d Compare January 28, 2025 22:29
lukaszstolarczuk
lukaszstolarczuk reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor
@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igchor igchor force-pushed the l0_page_query_ordinal branch from 7709e9d to 5e1f9d8 Compare January 29, 2025 15:36
@lukaszstolarczuk lukaszstolarczuk merged commit 660f1f4 into oneapi-src:main Jan 31, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lplewa lplewa lplewa left review comments

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk left review comments

@PatKamin PatKamin PatKamin left review comments

@vinser52 vinser52 vinser52 approved these changes

@bratpiorka bratpiorka bratpiorka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@igchor @vinser52 @bratpiorka @lplewa @lukaszstolarczuk @PatKamin
0