Update to v0.2 (nested storage) with FSStore #75
Conversation
With the improvements to zarr.store.FSStore, all URLs can be handled uniformly without needing to use `requests`. A next step may in fact be to remove the ZarrLocation types. This change does not yet support v0.2 and v0.1 at the same time.
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 66.85% 66.95% +0.09%
==========================================
Files 11 11
Lines 1056 1053 -3
==========================================
- Hits 706 705 -1
+ Misses 350 348 -2
Continue to review full report at Codecov.
|
With the introduction of FSStore, nearly all of the local vs remote logic is now happening behind the scenes. The additional benefit is that this should appease the Windows implementation which was still failing with the previous commit.
|
Note: this requires Zarr 2.7.1. See zarr-developers/zarr-python#718 |
Unfortunately, the ZarrLocation level isn't activated on individual arrays only on groups.
| @property | ||
| def root_attrs(self) -> JSONDict: | ||
| """Return the contents of the zattrs file.""" | ||
| return dict(self.__metadata) | ||
|
|
||
| def load(self, subpath: str = "") -> da.core.Array: | ||
| def load(self, subpath: str = "", nested: bool = False) -> da.core.Array: |
There was a problem hiding this comment.
Going forward, we expect all future specs will be nested, so would it make sense for the default nested: bool = True?
|
I must be doing something wrong here: Opens Same for |
|
Which zarr version? You'll need 2.7.1 |
|
Ah, thanks - That would have taken me a while to figure out. I had |
|
The SPW images exported via But not the plate itself (visible in vizarr with nested PR): Trying to open a nested plate with this PR (same error with the 'nested' plate above, or an older v0.1 plate): This also fails using the current master branch (c3f641d) but with a different error: And in fact it's not working for any of the older versions of |
|
|
Filed an issue for the dangling issue. Merging and releasing. |
With the improvements to zarr.store.FSStore, all URLs can
be handled uniformly without needing to use
requests. Anext step may in fact be to remove the ZarrLocation types.
This change does not yet support v0.2 and v0.1 at the same
time.