8000 fix: prevent overwriting existing systemd service file by autoexpect · Pull Request #13203 · ollama/ollama · GitHub

fix: prevent overwriting existing systemd service file #13203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

autoexpect wants to merge 1 commit into ollama:main from autoexpect:install-scripts-dev

+6 −2

autoexpect commented

Changes

Added existence check before creating ollama.service
Display informative message when service file already exists
Prevents accidental overwrite of custom systemd configurations

Motivation

During installation/upgrade, the script was unconditionally overwriting
the systemd service file, which could destroy user customizations such as:

Custom environment variables
Modified resource limits
Custom startup parameters

Impact

Safer upgrades that preserve user configurations
Better user experience for those who have customized the service
No breaking changes for fresh installations


          fix: prevent overwriting existing systemd service file

a37671d

Signed-off-by: Zhang Rui <rui.crater@gmail.com>

Collaborator

rick-github commented

User customizations go in the override file which is not affected by installation/upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

0