[FIX] html_builder: the carousel container title not recomputed after reordering #4687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
FrancoisGe
reviewed
May 16, 2025
Comment on lines
143
to
149
| const isContainerTitleEmpty = | ||
| newContainers.every( | ||
| (container) => Object.keys(container.containerTitle).length === 0 | ||
| ) && | ||
| this.lastContainers.every( | ||
| (container) => Object.keys(container.containerTitle).length === 0 | ||
| ); |
There was a problem hiding this comment.
Why not check if each container title are similar or not ?
fac5baf to
f620fc5
Compare
f620fc5 to
0318a0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.