fix presets preview #4670
Open
fix presets preview #4670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
ged-odoo
reviewed
May 14, 2025
ac0c790 to
d106b59
Compare
ec1852c to
b63d27b
Compare
Goaman
reviewed
May 15, 2025
Comment on lines
+114
to
+121
| let themePresets = undefined; | ||
| if (this.props.enabledTabs && this.props.enabledTabs.includes("theme")) { | ||
| const iframeDocument = document.querySelector("iframe").contentWindow.document; | ||
| const iframeStyle = iframeDocument.defaultView.getComputedStyle( | ||
| iframeDocument.documentElement | ||
| ); | ||
| themePresets = getThemePresets(iframeStyle); | ||
| } |
document.querySelector("iframe") isn't robust. What if another iframe matches because the code changes in the future.
Can't the iframe or iframeStyle be passed as a props or through the env?
There was a problem hiding this comment.
I can pass it as a props but I still need to get it from somewhere. How can I robustly get it ? Is there a reference to the iframe stored somewhere ?
031fec2 to
ed6ea41
Compare
ed6ea41 to
b379bb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[QSM, firefox] Go the theme tab -> Change the button colors of each color preset -> Add a snippet -> Open the colorpicker to change the background => The preview are not using the new colors