[IMP] estate: add SQL constraints for expected and selling prices in …

…property model; enforce unique name constraints in property tag and type models
odoo · pavy-odoo · Apr 23, 2025 · Apr 23, 2025 · Apr 23, 2025 · Apr 23, 2025
commit 94b71d056b19800fcee59346cf11f27fc913405e
diff --git a/estate/models/estate_property.py b/estate/models/estate_property.py
@@ -1,11 +1,24 @@
 from odoo import models, fields, api
 from dateutil.relativedelta import relativedelta
 from odoo.exceptions import UserError
+from odoo.tools.float_utils import float_compare, float_is_zero
 
 
 class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "Estate Property"
+    _sql_constraints = [
+        (
+            "check_expected_price",
+            "CHECK(expected_price > 0)",
+            "A property expected price must be strictly positive",
+        ),
+        (
+            "check_selling_price",
+            "CHECK(selling_price >= 0)",
+            "A property selling price must be positive",
+        ),
+    ]
 
     name = fields.Char(required=True)
     description = fields.Text()
@@ -105,14 +118,22 @@ def action_sold(self):
                 raise UserError("You cannot sell an already sold property")
             if record.state == "cancelled":
                 raise UserError("Cancelled Property can't be sold")
-            accepted_offer = record.offer_ids.filtered(lambda offer: offer.status == "accepted")
+            accepted_offer = record.offer_ids.filtered(
+                lambda offer: offer.status == "accepted"
+            )
             if not accepted_offer:
                 raise UserError("You cannot sell a property without an accepted offer")
-            record.write({'state': 'sold'})
+            record.write({"state": "sold"})
 
     def action_cancel(self):
         for record in self:
             if record.state != "sold":
                 record.state = "cancelled"
             else:
                 raise UserError("Sold Property can't be cancelled")
+
+    @api.constrains('expected_price', 'selling_price')
+    def _check_selling_price(self):
+        for record in self:
+            if not float_is_zero(record.selling_price, precision_digits=2) and float_compare(record.selling_price, 0.9 * record.expected_price, precision_digits=2) < 0:
+                    raise UserError("The selling price cannot be lower than 90% of the expected price.")
diff --git a/estate/models/estate_property_offer.py b/estate/models/estate_property_offer.py
@@ -6,6 +6,13 @@
 class EstatePropertyOffer(models.Model):
     _name = "estate.property.offer"
     _description = "Estate Property Offer"
+    _sql_constraints = [
+        (
+            "check_price",
+            "CHECK(price > 0)",
+            "An offer price must be strictly positive",
+        )
+    ]
 
     price = fields.Float("Price", required=True)
     status = fields.Selection(

diff --git a/estate/models/estate_property_tag.py b/estate/models/estate_property_tag.py
@@ -4,5 +4,12 @@
 class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
     _description = "Property Tag"
+    _sql_constraints = [
+        (
+            "check_name",
+            "UNIQUE(name)",
+            "The name must be unique",
+        )
+    ]
 
     name = fields.Char("Name", required=True)
diff --git a/estate/models/estate_property_type.py b/estate/models/estate_property_type.py
@@ -4,5 +4,12 @@
 class EstatePropertyType(models.Model):
     _name = "estate.property.type"
     _description = "Estate Property Type"
+    _sql_constraints = [
+        (
+            "check_name",
+            "UNIQUE(name)",
+            "The name must be unique",
+        )
+    ]
 
     name = fields.Char("Name", required=True)