[FW][FIX] website_payment: split test to avoid iframe issue #210494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On slow networks, users or runbot may click checkboxes before the JavaScript is fully loaded by the lazy loader, causing event handlers to not be attached. While test tours are supposed to be robust enough to wait for that, it was decided to split the test into two separate tours, as testing the donation form use from a non-admin is also better. So: one part while logged in as admin for donation configuration, and another while logged in as portal user to test it (we use a portal user so that the 8000 form still autocompletes with base user information). runbot-77224 X-original-commit: c4418cd Co-authored-by: qsm-odoo <qsm@odoo.com>
Since the new tour system that was introduced through many commits leading to 18.0, this donation test was left with errors and/or useless things. Related to runbot-77224 X-original-commit: 74c9c92
|
|
|
@alessandro-caldonazzi @qsm-odoo this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
qsm-odoo
approved these changes
May 19, 2025
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
May 20, 2025
On slow networks, users or runbot may click checkboxes before the JavaScript is fully loaded by the lazy loader, causing event handlers to not be attached. While test tours are supposed to be robust enough to wait for that, it was decided to split the test into two separate tours, as testing the donation form use from a non-admin is also better. So: one part while logged in as admin for donation configuration, and another while logged in as portal user to test it (we use a portal user so that the form still autocompletes with base user information). runbot-77224 X-original-commit: c4418cd Part-of: #210494 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Co-authored-by: qsm-odoo <qsm@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 20, 2025
On slow networks, users or runbot may click checkboxes before the JavaScript is fully loaded by the lazy loader, causing event handlers to not be attached. While test tours are supposed to be robust enough to wait for that, it was decided to split the test into two separate tours, as testing the donation form use from a non-admin is also better. So: one part while logged in as admin for donation configuration, and another while logged in as portal user to test it (we use a portal user so that the form still autocompletes with base user information). runbot-77224 X-original-commit: c4418cd Part-of: #210494 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Co-authored-by: qsm-odoo <qsm@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 20, 2025
On slow networks, users or runbot may click checkboxes before the JavaScript is fully loaded by the lazy loader, causing event handlers to not be attached. While test tours are supposed to be robust enough to wait for that, it was decided to split the test into two separate tours, as testing the donation form use from a non-admin is also better. So: one part while logged in as admin for donation configuration, and another while logged in as portal user to test it (we use a portal user so that the form still autocompletes with base user information). runbot-77224 X-original-commit: c4418cd Part-of: #210494 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Co-authored-by: qsm-odoo <qsm@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 20, 2025
On slow networks, users or runbot may click checkboxes before the JavaScript is fully loaded by the lazy loader, causing event handlers to not be attached. While test tours are supposed to be robust enough to wait for that, it was decided to split the test into two separate tours, as testing the donation form use from a non-admin is also better. So: one part while logged in as admin for donation configuration, and another while logged in as portal user to test it (we use a portal user so that the form still autocompletes with base user information). runbot-77224 X-original-commit: c4418cd Part-of: #210494 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Co-authored-by: qsm-odoo <qsm@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 20, 2025
On slow networks, users or runbot may click checkboxes before the JavaScript is fully loaded by the lazy loader, causing event handlers to not be attached. While test tours are supposed to be robust enough to wait for that, it was decided to split the test into two separate tours, as testing the donation form use from a non-admin is also better. So: one part while logged in as admin for donation configuration, and another while logged in as portal user to test it (we use a portal user so that the form still autocompletes with base user information). runbot-77224 X-original-commit: c4418cd Part-of: #210494 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Co-authored-by: qsm-odoo <qsm@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 20, 2025
On slow networks, users or runbot may click checkboxes before the JavaScript is fully loaded by the lazy loader, causing event handlers to not be attached. While test tours are supposed to be robust enough to wait for that, it was decided to split the test into two separate tours, as testing the donation form use from a non-admin is also better. So: one part while logged in as admin for donation configuration, and another while logged in as portal user to test it (we use a portal user so that the form still autocompletes with base user information). runbot-77224 X-original-commit: c4418cd Part-of: #210494 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Co-authored-by: qsm-odoo <qsm@odoo.com>
fdardenne
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 26, 2025
On slow networks, users or runbot may click checkboxes before the JavaScript is fully loaded by the lazy loader, causing event handlers to not be attached. While test tours are supposed to be robust enough to wait for that, it was decided to split the test into two separate tours, as testing the donation form use from a non-admin is also better. So: one part while logged in as admin for donation configuration, and another while logged in as portal user to test it (we use a portal user so that the form still autocompletes with base user information). runbot-77224 X-original-commit: c4418cd Part-of: odoo#210494 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Co-authored-by: qsm-odoo <qsm@odoo.com>
fdardenne
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 26, 2025
Since the new tour system that was introduced through many commits leading to 18.0, this donation test was left with errors and/or useless things. Related to runbot-77224 closes odoo#210494 X-original-commit: 74c9c92 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On slow networks, users or runbot may click checkboxes before the
JavaScript is fully loaded by the lazy loader, causing event handlers
to not be attached.
Fix: Split the test into two separate tours. One while logged in for
donation configuration, and another while logged out to test it, since
the issue does not occur when the iframe is not present.
Tested with a custom multi-build and the test do not fail anymore
runbot-77224
Forward-Port-Of: #210238
Forward-Port-Of: #179885