[FW][FIX] mail: ensure call starter name is displayed correctly #210491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purpose of this commit : The name was appearing as undefined because message.author.name was not set for portal users. to handle this, we used message.authorName directly. also it was changed to message.authorName to be consistent with the rest of the code. task-4782291 X-original-commit: 3604b52
|
|
|
@jayp-odoo @alexkuhn this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@jayp-odoo @alexkuhn ci/runbot failed on this forward-port PR |
|
@robodoo r+ |
|
@jayp-odoo @alexkuhn staging failed: ci/runbot on c3dbfde24685bf99495d2469c526ca77a3713cf2 (view more at https://runbot.odoo.com/runbot/build/80624117) |
|
robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
May 18, 2025
purpose of this commit : The name was appearing as undefined because message.author.name was not set for portal users. to handle this, we used message.authorName directly. also it was changed to message.authorName to be consistent with the rest of the code. task-4782291 closes #210491 X-original-commit: 3604b52 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com> Signed-off-by: Jay Patel (jayp) <jayp@odoo.com>
fdardenne
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 26, 2025
purpose of this commit : The name was appearing as undefined because message.author.name was not set for portal users. to handle this, we used message.authorName directly. also it was changed to message.authorName to be consistent with the rest of the code. task-4782291 closes odoo#210491 X-original-commit: 3604b52 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com> Signed-off-by: Jay Patel (jayp) <jayp@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purpose of this PR :
The name was appearing as undefined because message.author.name was not set
for portal users. to handle this, we used
message.authorNamedirectly. also it waschanged to
message.authorNameto be consistent with the rest of the code.task-4782291
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #209389