8000 [FW][FIX] l10n_it_edi_ndd: recompute l10n_it_document_type for credit note by fw-bot · Pull Request #210361 · odoo/odoo · GitHub
[go: up one dir, main page]

Skip to content

[FW][FIX] l10n_it_edi_ndd: recompute l10n_it_document_type for credit note #210361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fw-bot
Copy link
Contributor
@fw-bot fw-bot commented May 16, 2025

Steps to reproduce:

  • Install l10n_it_edi_ndd
  • Switch to an Italian company (e.g. IT Company)
  • Create an invoice
  • Confirm the invoice
    => Document Type (in "Electronic Invoicing" tab) is computed
  • Create a credit note from the invoice
  • On credit note wizard, click on "Reverse and Create Invoice"
  • Check the created credit note

Issue:
The credit note is posted but its Document Type field (l10n_it_document_type) is empty.
l10n_it_document_type should be computed when it doesn't have a value already and the state of the move is "posted".
The credit note will be rejected when sent to SDI because this field is empty.

Cause:
In the reverse method, the field is set to False in order to be recomputed.
However, the compute method is triggered when the state changes, but the credit note not is already posted.
Therefore the field will not be recomputed.

Solution:
Set the value to False before the creation of the credit note.
So that, the field will be recomputed when posting the credit note.

opw-4689755


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #208654

@robodoo
Copy link
Contributor
robodoo commented May 16, 2025

Pull request status dashboard

@fw-bot
Copy link
Contributor Author
fw-bot commented May 16, 2025

This PR targets 18.0 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label May 16, 2025
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label May 16, 2025
@fw-bot
Copy link
Contributor Author
fw-bot commented May 16, 2025

@kitan191 @Megaaaaaa ci/l10n failed on this forward-port PR

Steps to reproduce:
- Install l10n_it_edi_ndd
- Switch to an Italian company (e.g. IT Company)
- Create an invoice
- Confirm the invoice
=> Document Type (in "Electronic Invoicing" tab) is computed
- Create a credit note from the invoice
- On credit note wizard, click on "Reverse and Create Invoice"
- Check the created credit note

Issue:
The credit note is posted but its Document Type field (l10n_it_document_type)
is empty.
l10n_it_document_type should be computed when it doesn't have a value already
and the state of the move is "posted".
The credit note will be rejected when sent to SDI because this field is empty.

Cause:
In the reverse method, the field is set to False in order to be recomputed.
However, the compute method is triggered when the state changes, but the
credit note is already posted.
Therefore the field will not be recomputed.

Solution:
Set the value to False before the creation of the credit note.
So that, the field will be recomputed when posting the credit note.

opw-4689755

X-original-commit: 4dfcce2
@kitan191 kitan191 force-pushed the 18.0-17.0-opw-4689755-fix_l10n_it_document_type_compute_reverse-pta-436683-fw branch from 969513e to 35b3670 Compare May 16, 2025 15:56
@fw-bot
Copy link
Contributor Author
fw-bot commented May 16, 2025

@kitan191 @Megaaaaaa this PR was modified / updated and has become a normal PR. It must be merged directly.

@kitan191
Copy link
Contributor

@robodoo r+

@robodoo robodoo closed this in de832b1 May 17, 2025
acsonefho pushed a commit to acsone/odoo that referenced this pull request May 19, 2025
Steps to reproduce:
- Install l10n_it_edi_ndd
- Switch to an Italian company (e.g. IT Company)
- Create an invoice
- Confirm the invoice
=> Document Type (in "Electronic Invoicing" tab) is computed
- Create a credit note from the invoice
- On credit note wizard, click on "Reverse and Create Invoice"
- Check the created credit note

Issue:
The credit note is posted but its Document Type field (l10n_it_document_type)
is empty.
l10n_it_document_type should be computed when it doesn't have a value already
and the state of the move is "posted".
The credit note will be rejected when sent to SDI because this field is empty.

Cause:
In the reverse method, the field is set to False in order to be recomputed.
However, the compute method is triggered when the state changes, but the
credit note is already posted.
Therefore the field will not be recomputed.

Solution:
Set the value to False before the creation of the credit note.
So that, the field will be recomputed when posting the credit note.

opw-4689755

closes odoo#210361

X-original-commit: 4dfcce2
Signed-off-by: Thomas Becquevort (thbe) <thbe@odoo.com>
Signed-off-by: Anh Thao Pham (pta) <pta@odoo.com>
@fw-bot fw-bot deleted the 18.0-17.0-opw-4689755-fix_l10n_it_document_type_compute_reverse-pta-436683-fw branch May 24, 2025 04:11
ThomasSchneider-94 pushed a commit to odoo-dev/odoo that referenced this pull request Jun 4, 2025
Steps to reproduce:
- Install l10n_it_edi_ndd
- Switch to an Italian company (e.g. IT Company)
- Create an invoice
- Confirm the invoice
=> Document Type (in "Electronic Invoicing" tab) is computed
- Create a credit note from the invoice
- On credit note wizard, click on "Reverse and Create Invoice"
- Check the created credit note

Issue:
The credit note is posted but its Document Type field (l10n_it_document_type)
is empty.
l10n_it_document_type should be computed when it doesn't have a value already
and the state of the move is "posted".
The credit note will be rejected when sent to SDI because this field is empty.

Cause:
In the reverse method, the field is set to False in order to be recomputed.
However, the compute method is triggered when the state changes, but the
credit note is already posted.
Therefore the field will not be recomputed.

Solution:
Set the value to False before the creation of the credit note.
So that, the field will be recomputed when posting the credit note.

opw-4689755

closes odoo#210361

X-original-commit: 4dfcce2
Signed-off-by: Thomas Becquevort (thbe) <thbe@odoo.com>
Signed-off-by: Anh Thao Pham (pta) <pta@odoo.com>
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Jun 4, 2025
Steps to reproduce:
- Install l10n_it_edi_ndd
- Switch to an Italian company (e.g. IT Company)
- Create an invoice
- Confirm the invoice
=> Document Type (in "Electronic Invoicing" tab) is computed
- Create a credit note from the invoice
- On credit note wizard, click on "Reverse and Create Invoice"
- Check the created credit note

Issue:
The credit note is posted but its Document Type field (l10n_it_document_type)
is empty.
l10n_it_document_type should be computed when it doesn't have a value already
and the state of the move is "posted".
The credit note will be rejected when sent to SDI because this field is empty.

Cause:
In the reverse method, the field is set to False in order to be recomputed.
However, the compute method is triggered when the state changes, but the
credit note is already posted.
Therefore the field will not be recomputed.

Solution:
Set the value to False before the creation of the credit note.
So that, the field will be recomputed when posting the credit note.

opw-4689755

closes odoo/odoo#210361

X-original-commit: 4dfcce2d13af8036cb9403066d656c72f81c6092
Signed-off-by: Thomas Becquevort (thbe) <thbe@odoo.com>
Signed-off-by: Anh Thao Pham (pta) <pta@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0