[FIX] mail: fix info displayed on activity #210060
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This commit fixes an issue introduced by de26b96 where some fields of the activity records weren't properly read. Notably `activity_type_id` and `create_uid` which only returned their ID instead of returning (ID, name). This led to a wrong display of the additional informations inside the activities in the Chatter. Where the type of activity and its creator were empty. To fix this, we reimplement the _to_store method so that we properly read the fields while letting the store add their specific fields. task-4794562
f49033e to
b5523f0
Compare
|
@robodoo r+ As discussed, ok for a quick fix, then maybe to cleanup in master / when having a bit of time :) . |
robodoo
pushed a commit
that referenced
this pull request
May 15, 2025
This commit fixes an issue introduced by de26b96 where some fields of the activity records weren't properly read. Notably `activity_type_id` and `create_uid` which only returned their ID instead of returning (ID, name). This led to a wrong display of the additional informations inside the activities in the Chatter. Where the type of activity and its creator were empty. To fix this, we reimplement the _to_store method so that we properly read the fields while letting the store add their specific fields. task-4794562 closes #210060 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
pushed a commit
that referenced
this pull request
May 15, 2025
This commit fixes an issue introduced by de26b96 where some fields of the activity records weren't properly read. Notably `activity_type_id` and `create_uid` which only returned their ID instead of returning (ID, name). This led to a wrong display of the additional informations inside the activities in the Chatter. Where the type of activity and its creator were empty. To fix this, we reimplement the _to_store method so that we properly read the fields while letting the store add their specific fields. task-4794562 closes #210060 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
|
Hello, this is definitely not the right fix, why isn't the problematic code adapted to the new format instead? |
|
Here is the PR: #210296 Can you confirm this fixes the issues you had in mind? |
See bug at https://www.odoo.com/odoo/project/10888/tasks/4794562 |
seb-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
May 16, 2025
Follow up of odoo#189598 Follow up of odoo#210060 task-4794562
seb-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
May 19, 2025
Follow up of odoo#189598 Follow up of odoo#210060 task-4794562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue introduced by de26b96 where some fields of the activity records weren't properly read. Notably
activity_type_idandcreate_uidwhich only returned their ID instead of returning (ID, name).This led to a wrong display of the additional informations inside the activities in the Chatter. Where the type of activity and its creator were empty. To fix this, we reimplement the _to_store method so that we properly read the fields while letting the store add their specific fields.
task-4794562
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr