[ADD] referrals: moving share jobs section to new doc #9319
Conversation
28e84cb to
ea207ba
Compare
ea207ba to
1f90f59
Compare
1f90f59 to
096d26b
Compare
|
Hi @brse-odoo - this is ready for a peer review when you have a moment! |
There was a problem hiding this comment.
Hi @larm-odoo just finished my review of this PR, great job! I had very few suggestions for you to accept/reject as you see fit. Let me know if you have any questions, thanks!
096d26b to
90dfe37
Compare
|
This is ready for a final review, @ksc-odoo! |
There was a problem hiding this comment.
Hey @larm-odoo -- just finished my Final Review. Approving now. Great work. Once you address the comments I've left, and implement the necessary changes, feel free to tag this for Tech Review. Thanks! 👍
90dfe37 to
555d231
Compare
555d231 to
f962ca2
Compare
|
This is ready for a tech review, @samueljlieber! I wasn't sure how ot handle the twitter section since it's just "x"/ For that icon, I didn't use a GUI after it since it is already an X - and there isn't an official X icon in the font awesome library yet. Curious to see what you think! |
There was a problem hiding this comment.
Hi @larm-odoo, nice PR to break down the Referrals doc into smaller pieces. I have a handful of comments for you, please let me know if you have any questions.
All of the images introduced in this 15.0 PR appear to be on 17.0, can you please retake these for the correct version of the PR, and ensure all instructions are 15.0 specific?
Please update the title of the PR to match the commit message (via the Edit button).
The following images need to be removed as they are unused:
email.png
facebook.png
jobs.png
linkedin.png
share_job.rst
share.png
twitter.png
Also, there is an accidental file named q included, please remove this too 😉
Please tag me for another look once these have been addressed, thank you!
f962ca2 to
c72adcf
Compare
|
Thank you @samueljlieber - it didn't occur to me to check some of those other items (moved images, etc) since I was juts "moving" the info, lol. Everything has been updated- ready for another peek! |
There was a problem hiding this comment.
Hi @larm-odoo, just a couple more comments from my review, please see below. Approving and delegating merge to you! Thank you!
Please update the media folder name (and all image paths) to replace the "-" with an "_":
share-jobs/ ➡️ share_jobs/
..
@robodoo delegate=larm-odoo
c72adcf to
264221d
Compare
|
@robodoo r+ |
closes #9319 Signed-off-by: Lara Martini (larm) <larm@odoo.com>
|
@larm-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
3 similar comments
|
@larm-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@larm-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@larm-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@larm-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
2 similar comments
|
@larm-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@larm-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
Moving the 'Share Jobs' section to its own doc since it can stand alone- the main doc is too long. This is to help cut up the doc into more digestible parts.
Project Task Card.