-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[IMP] tutorials/server_framework_101: rewrite the tutorial #9192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
426409a
to
7bb6a8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small suggestions
content/developer/tutorials/server_framework_101/01_architecture_overview.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/01_architecture_overview.rst
Show resolved
Hide resolved
1b81622
to
e272f5d
Compare
1be9338
to
6499ee4
Compare
6499ee4
to
f2f3e50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chapter 2 is super clear with a lot of valuable info for understanding the framework!
f602970
to
5c12ae4
Compare
df1236b
to
739e4ca
Compare
ffaee73
to
2104739
Compare
5011617
to
fd29272
Compare
a510322
to
2e30832
Compare
2e30832
to
6ef06b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very solid work!
Here are some small comments.
content/developer/tutorials/server_framework_101/04_relational_fields.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/04_relational_fields.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/04_relational_fields.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/04_relational_fields.rst
Outdated
Show resolved
Hide resolved
ea6a7c9
to
0bbf2d5
Compare
content/developer/tutorials/server_framework_101/02_lay_the_foundations.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/04_relational_fields.rst
Outdated
Show resolved
Hide resolved
9fbf595
to
ee8a1a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress!
Here are some small comments/suggestions :)
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
ee8a1a9
to
8bc3a1b
Compare
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/04_relational_fields.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/04_relational_fields.rst
Outdated
Show resolved
Hide resolved
1fc06be
to
ff014f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress!
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
e423dde
to
caaf822
Compare
b109024
to
d2baef5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work!
It is progressing fast!
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Outdated
Show resolved
Hide resolved
ce1db01
to
dbe3410
Compare
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/05_connect_the_dots.rst
Show resolved
Hide resolved
a5139d0
to
5fcfde4
Compare
The Server Framework 101 (formerly Getting Started) is generally seen as an interesting and rewarding tutorial, but also somewhat outdated and too limited for beginners in Odoo development, as it fails to introduce key concepts of the server framework (e.g., controllers, tests, etc.). The instructions are also too directive for the reader to try and search by themselves and learn from it. With this commit, all of the content of the tutorial is rewritten while keeping the objective of building a real estate module. The setup guide for tutorials is also improved to ensure smoother onboarding for Odoo employees and community members alike. task-3802536
61b6252
to
5e40de9
Compare
5e40de9
to
6b03f6f
Compare
df80bdf
to
1357579
Compare
content/developer/tutorials/server_framework_101/06_security.rst
Outdated
Show resolved
Hide resolved
content/developer/tutorials/server_framework_101/06_security.rst
Outdated
Show resolved
Hide resolved
- **Context-aware dependencies**: The `@api.depends_context('company')` decorator ensures that | ||
computed fields are computed depending on the current company (`self.env.company`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are cached (and computed) depending on the environment company.
Maybe a tip to say that it shouldn't be used on stored fields (unless you really know what you're doing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to omit it for now because we're in the scope of a tutorial where the reader has to learn pretty much everything. It should however be properly state in the reference doc.
content/developer/tutorials/server_framework_101/06_security.rst
Outdated
Show resolved
Hide resolved
1357579
to
b72d196
Compare
accessing data like company-dependent fields, allowing to retrieve values from a specific | ||
company's perspective. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retrieve values and trigger flows from a specific company perspective ?
It's not only about retrieving values (though not sure how to clearly explain it here).
In the case where a users selects company A and B (A as main) but triggers a flow on B, it's a good practice to trigger the flow in company B to make sure nothings breaks (or is wrongly configured).
The Server Framework 101 (formerly Getting Started) is generally seen as an interesting and rewarding tutorial, but also somewhat outdated and too limited for beginners in Odoo development, as it fails to introduce key concepts of the server framework (e.g., controllers, tests, etc.). The instructions are also too directive for the reader to try and search
by themselves and learn from it.
With this commit, all of the content of the tutorial is rewritten while keeping the objective of building a real estate module. The setup guide for tutorials is also improved to ensure smoother onboarding for Odoo employees and community members alike.
task-3802536