8000 [ADD] payment_providers: Xendit by nni-odoo · Pull Request #6045 · odoo/documentation · GitHub
[go: up one dir, main page]
Skip to content

[ADD] payment_providers: Xendit #6045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ADD] payment_providers: Xendit #6045

wants to merge 1 commit into from

Conversation

nni-odoo
Copy link
Contributor
@nni-odoo nni-odoo commented Oct 6, 2023 •
edited by AntoineVDV
Loading

Documentation for Xendit payment provider

taskid-2946329

See also:

@nni-odoo nni-odoo requested a review from toaa-odoo October 6, 2023 06:54
@robodoo
Copy link
Collaborator
robodoo commented Oct 6, 2023

Pull request status dashboard.

@nni-odoo nni-odoo force-pushed the master-payment_xendit-nni branch from a654312 to 3cffa53 Compare October 6, 2023 06:55
@nni-odoo
Copy link
Contributor Author
nni-odoo commented Oct 6, 2023

Hi @toaa-odoo this is the documentation for the master branch. I've added you as the reviewer here since you reviewed my PR before (to 16.3) https://github.com/odoo/documentation/pull/5852/commits. Thanks again!

@C3POdoo C3POdoo requested a review from a team October 6, 2023 06:57
@toaa-odoo toaa-odoo force-pushed the master-payment_xendit-nni branch from 3cffa53 to 268ddb9 Compare October 6, 2023 11:15
toaa-odoo
toaa-odoo approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor
@toaa-odoo toaa-odoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging the next reviewer in line :)

@toaa-odoo toaa-odoo requested a review from a team October 6, 2023 11:26
@toaa-odoo toaa-odoo mentioned this pull request Oct 6, 2023
Closed
@xpl-odoo xpl-odoo force-pushed the master-payment_xendit-nni branch from 268ddb9 to d8be594 Compare October 26, 2023 14:36
@xpl-odoo
Copy link
Contributor

Hi @nni-odoo ! I pushed some changes to go faster.

I removed the part about checking the boxes below the "Invoices: Invoices paid" URL in the Webhook section. This didn't feel necessary (you can) without explaining what's their use. But feel free to add it back if you believe it's essential.

You can r+ whenever.

@robodoo delegate+

@nni-odoo nni-odoo changed the base branch from master to 17.0 January 8, 2024 09:40
@AntoineVDV AntoineVDV mentioned this pull request Jan 8, 2024
Closed
@nni-odoo nni-odoo requested a review from auva-odoo January 8, 2024 10:33
auva-odoo
auva-odoo requested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor
@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nni-odoo thank you very much for writing this doc!
In addition to my comments, I'd like to suggest merging all sub-sections under the first h2 to have just one big numbered list with all the steps that need to be done on the Xendit dashboard.
If it's ok with you, don't forget to remove repetitions, e.g., we don't need to go to Configuration: Settings and select Developers a second time, we can just stay on the same page and scroll down to the Webhooks section (or select it in the small menu) and go from there:
xendit-developers-menu

Don't hesitate if you have any questions!

@nni-odoo nni-odoo requested a review from auva-odoo January 10, 2024 03:25
8000
@nni-odoo
Copy link
Contributor Author

@auva-odoo thank you for the suggestions! I've revised the document and followed your suggestion on combining the sub-sections under the first h2. Let me know if there's anything else I should revise!

auva-odoo
auva-odoo requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor
@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nni-odoo I've added a few more suggestions/comments. Also, could you please keep lines within 100 characters? Thank you!

@nni-odoo nni-odoo requested a review from auva-odoo January 10, 2024 09:14
@nni-odoo
Copy link
Contributor Author

@auva-odoo revised the doc again and limited each line to <= 100 characters! Let me know if there's anything else!

@auva-odoo auva-odoo force-pushed the master-payment_xendit-nni branch from 3537c4b to 6fbd653 Compare January 10, 2024 09:27
auva-odoo
auva-odoo approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor
@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nni-odoo I force-pushed to add one tiny little missing comma, but otherwise it looks good to me! Thank you again for your work on this, you can r+ whenever you're ready :)

@robodoo delegate+

@nni-odoo
Copy link
Contributor Author

@auva-odoo Thank you for your help! I'll wait for the main PR odoo/odoo#141661 to be merged.
On that note, do I need to squash all commits when merging? If so, is it done automatically through r+?

@auva-odoo
Copy link
Contributor
auva-odoo commented Jan 10, 2024 •
edited
Loading

@nni-odoo Yes you do need to squash them before merging; it's not done automatically

628C
@AntoineVDV
Copy link
Collaborator

@nni-odoo Could you squash the commits without rebasing on a fresh 17.0 (use git rebase -i HEAD~4) and r+ yourself?

@nni-odoo
[ADD] payment_providers: Xendit
829c119 
Documentation for Xendit payment provider

taskid-2946329
@nni-odoo nni-odoo force-pushed the master-payment_xendit-nni branch from 6fbd653 to 829c119 Compare January 22, 2024 00:52
@nni-odoo
Copy link
Contributor Author

@robodoo r+

@nni-odoo
Copy link
Contributor Author

@AntoineVDV thank you!

@robodoo robodoo closed this in 05637af Jan 22, 2024
This was referenced Jan 22, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toaa-odoo toaa-odoo toaa-odoo approved these changes

@auva-odoo auva-odoo auva-odoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nni-odoo @robodoo @xpl-odoo @auva-odoo @AntoineVDV @toaa-odoo
0