-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[ADD] payment_providers: Xendit #6045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a654312
to
3cffa53
Compare
Hi @toaa-odoo this is the documentation for the master branch. I've added you as the reviewer here since you reviewed my PR before (to 16.3) https://github.com/odoo/documentation/pull/5852/commits. Thanks again! |
3cffa53
to
268ddb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging the next reviewer in line :)
268ddb9
to
d8be594
Compare
Hi @nni-odoo ! I pushed some changes to go faster. I removed the part about checking the boxes below the "Invoices: Invoices paid" URL in the Webhook section. This didn't feel necessary (you can) without explaining what's their use. But feel free to add it back if you believe it's essential. You can r+ whenever. @robodoo delegate+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nni-odoo thank you very much for writing this doc!
In addition to my comments, I'd like to suggest merging all sub-sections under the first h2 to have just one big numbered list with all the steps that need to be done on the Xendit dashboard.
If it's ok with you, don't forget to remove repetitions, e.g., we don't need to go to Configuration: Settings and select Developers a second time, we can just stay on the same page and scroll down to the Webhooks section (or select it in the small menu) and go from there:
Don't hesitate if you have any questions!
@auva-odoo thank you for the suggestions! I've revised the document and followed your suggestion on combining the sub-sections under the first h2. Let me know if there's anything else I should revise! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nni-odoo I've added a few more suggestions/comments. Also, could you please keep lines within 100 characters? Thank you!
@auva-odoo revised the doc again and limited each line to <= 100 characters! Let me know if there's anything else! |
3537c4b
to
6fbd653
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@auva-odoo Thank you for your help! I'll wait for the main PR odoo/odoo#141661 to be merged. |
@nni-odoo Yes you do need to squash them before merging; it's not done automatically |
@nni-odoo Could you squash the commits without rebasing on a fresh 17.0 (use |
Documentation for Xendit payment provider taskid-2946329
6fbd653
to
829c119
Compare
@robodoo r+ |
@AntoineVDV thank you! |
Documentation for Xendit payment provider
taskid-2946329
See also: