10000 [IMP] Fleet: Update accidents by larm-odoo · Pull Request #13372 · odoo/documentation · GitHub
[go: up one dir, main page]

Skip to content

[IMP] Fleet: Update accidents #13372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

Conversation

larm-odoo
Copy link
Contributor

Updating to new standards

@larm-odoo larm-odoo requested a review from a team May 14, 2025 19:00
@larm-odoo larm-odoo self-assigned this May 14, 2025
@larm-odoo larm-odoo added the 2 label May 14, 2025
@robodoo
Copy link
Collaborator
robodoo commented May 14, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team May 14, 2025 19:02
@larm-odoo larm-odoo requested a review from slinkous May 14, 2025 20:14
@larm-odoo
Copy link
Contributor Author

Hi @slinkous - this is ready for a peer review.

Copy link
Contributor
@slinkous slinkous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These looks like good clarifications on this doc, Lara! Internet consensus is against me on "anytime", so feel extra emboldened to ignore.

@larm-odoo larm-odoo force-pushed the 18.0-fleet-accidents-larm branch from 78ee4d9 to c99df7d Compare May 16, 2025 21:11
@larm-odoo larm-odoo requested review from a team and removed request for a team May 16, 2025 21:16
@larm-odoo
Copy link
Contributor Author

Hi @Felicious - this is ready for a final review =)

Copy link
Contributor
@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @larm-odoo !

Odoo's *Fleet* app offers multiple ways to track accidents. Below are step-by-step instructions for
only **one** method to monitor accidents and repair costs.
Odoo's **Fleet** app offers multiple ways to track accidents. Below are step-by-step instructions
for one possible method to monitor accidents and repair costs.

Structure
=========
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 14, let's add details on how to get to the service form (: (I had to click 2 links to figure out where to go)

For this use case, go to :menuselection:Fleet app --> Fleet --> Services, and on the :ref:service form <link to the section you have in the services doc>. Two :ref:service types <fleet/new-type> are created:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment but on line 17:

Slight mix-up on grammar (tense):

This tracks various repairs associated with accidents, organized by who was at fault.

Let's change it to:

This setup records repairs associated with accidents and organizes them by fault.

Odoo's *Fleet* app offers multiple ways to track accidents. Below are step-by-step instructions for
only **one** method to monitor accidents and repair costs.
Odoo's **Fleet** app offers multiple ways to track accidents. Below are step-by-step instructions
for one possible method to monitor accidents and repair costs.

Structure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure section is helpful for explaining how things are organized in Odoo while keeping this doc short, as this is covered in other docs. Good job!

@@ -5,8 +5,8 @@ Accidents
When managing a fleet, accidents are inevitable. Tracking accidents is crucial for understanding
vehicle maintenance costs and identifying safe drivers.

Odoo's *Fleet* app offers multiple ways to track accidents. Below are step-by-step instructions for
only **one** method to monitor accidents and repair costs.
Odoo's **Fleet** app offers multiple ways to track accidents. Below are step-by-step instructions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Odoo's **Fleet** app offers multiple ways to track accidents. Below are step-by-step instructions
Odoo's **Fleet** app offers multiple ways of tracking accidents. Below are step-by-step instructions

@@ -27,7 +27,7 @@ driver, or cost.
To manage accidents, the creation of service records is **required**.

Refer to the :doc:`service` documentation for detailed instructions on creating service records
in Odoo's *Fleet* app.
in Odoo's **Fleet** app.

Log accidents and repairs
=========================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 35, i think we have an extra comma: "To log an accident and initiate the repair process,"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 41: slight rewording for parallelism (:

"recommended to keep the Notes field identical, as well as attaching …” --> "recommended to keep the Notes field identical and attach …"

In this example, there are six accidents where the driver was at fault, and four accidents that
were not the driver's fault. This dashboard also displays the estimated total :guilabel:`Cost`
for all the accidents in each group.
In this example, there are three accidents where the driver was at fault, and one accidents that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In this example, there are three accidents where the driver was at fault, and one accidents that
In this example, there are three accidents where the driver was at fault, and one accident that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0