-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[IMP] localization: Add Chorus pro via Peppol information #12897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] localization: Add Chorus pro via Peppol information #12897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @afma-odoo thank you so much for the termendous work you've done on this doc page 💪 As always, feel free to reach out if there’s anything you’d like to discuss. I know I left quite a few (bigger) comments on the new section, and it can definitely get a bit confusing.
I did a lighter review on the rest of the doc, since the content was already there and you mostly "just" (😉) restructured and rephrased it.
875b28a
to
6ca2839
Compare
6ca2839
to
10c448e
Compare
Thanks @auva-odoo for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @afma-odoo thank you so miuch for the changes! I added a few minor comments (including ones for my own mistakes from my suggestions 🙈 so sorry about that!). Again, really nice work with this PR, thank you!
(as agreed since I'll be OoO)
@robodoo delegate+
task-4698357 task-4661523
10c448e
to
fa4cd10
Compare
@auva-odoo Thanks a lot for your review and all your great advice @robodoo r+ |
@afma-odoo you can't review+. |
@robodoo r+ |
@afma-odoo you can't review+. |
@robodoo r+ |
task-4698357 task-4661523 closes #12897 Signed-off-by: Xavier Platteau (xpl) <xpl@odoo.com>
task-4698357
task-4661523
For your info,
Thank you!