8000 [IMP] payment_xendit: registration link by nni-odoo · Pull Request #12211 · odoo/documentation · GitHub
[go: up one dir, main page]

Skip to content

[IMP] payment_xendit: registration link #12211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nni-odoo
Copy link
Contributor

Update the registration link to allow Xendit to track the accounts coming from Odoo

@robodoo
Copy link
Collaborator
robodoo commented Feb 27, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team February 27, 2025 10:04
Copy link
Collaborator
@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is requested by Xendit, they should probably use a different heuristic. People can drop the query param, already have an account, register through a different page...

Payment providers should typically determine if an account is connected to Odoo by inspecting the payload of the payment requests.

@jgr-odoo
Copy link

hello @AntoineVDV , Janice here from the Indonesia office. I discussed with Xendit regarding this link. Unfortunately they currently don't have tracker to detect if the client is from Odoo. So, the token link will be the easiest way to track whether a client is using the Xendit integration from Odoo or not. It's not perfect because indeed like what you said: some of them may have an account already, register through a different page, etc. It's something that they are aware too, but if we put it in our documentation, it can make people who read it to register through the token and at least we have a way to track them.

And, the purpose of this link is to keep track of Odoo's clients and therefore if any of the clients face issue, they can know its from Odoo and help them directly. Let me know what you think about this and feel free to tell me if you need further clarification from Xendit.

Thank you!
cc @nni-odoo

@AntoineVDV
Copy link
Collaborator

Hi @jgr-odoo, I'm not against merging this, but I think it'll be almost useless to them.

Most providers use a heuristic to deterministically determine if a merchant is using Odoo, instead of relying on the registration link, and only being right sometimes.

I'll let @auva-odoo review the PR because I don't know if we have guidelines against affiliate links in the documentation... I guess not 😀

Copy link
Contributor
@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntoineVDV No, we don't have any guidelines regarding tracked links so it's fine by me. @nni-odoo I did add a suggestion to fix the formatting and revert the wording to what is was. (Also, could you please make sure not to go over the 100th-character limit while we're at it 😉 ) Thank you!

@nni-odoo nni-odoo force-pushed the 17.0-xendit-registration-nni branch from f6619a7 to c8e4415 Compare April 25, 2025 04:04
@nni-odoo nni-odoo requested a review from auva-odoo April 25, 2025 04:04
@nni-odoo
Copy link
Contributor Author

@auva-odoo thanks for the feedback!

Update the registration link to allow Xendit to track the accounts coming from Odoo
@auva-odoo auva-odoo force-pushed the 17.0-xendit-registration-nni branch from c8e4415 to 21d13d6 Compare April 25, 2025 06:23
Copy link
Contributor
@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nni-odoo I pushed a small change to fix the failed check 😉 Thank you for your work!

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 25, 2025
Update the registration link to allow Xendit to track the accounts coming from Odoo

closes #12211

Signed-off-by: Audrey Vandromme (auva) <auva@odoo.com>
@robodoo robodoo closed this Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0