8000 [IMP] l10n_nz: Improve New Zealand localization module documentation by XIDO-odoo · Pull Request #12156 · odoo/documentation · GitHub
[go: up one dir, main page]
Skip to content

[IMP] l10n_nz: Improve New Zealand localization module documentation #12156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on Git 8000 Hub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[IMP] l10n_nz: Improve New Zealand localization module documentation #12156

wants to merge 1 commit into from

Conversation

XIDO-odoo
Copy link
Contributor

Following the release of the improvement on New Zealand localization, this PR includes additional information to the page

task-2858250

@robodoo
Copy link
Collaborator
robodoo commented Feb 24, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team February 24, 2025 08:55
@afma-odoo afma-odoo requested review from afma-odoo and removed request for a team February 26, 2025 07:30
@afma-odoo afma-odoo force-pushed the 18.0-Localization-NZ-XIDO branch 2 times, most recently from a8fd560 to 81c7492 Compare March 5, 2025 08:29
afma-odoo
afma-odoo requested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor
@afma-odoo afma-odoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ximo,
Thank you for this all your work on this page!
I force-pushed some changes related to the new guidelines/templates for loc documentation pages and also some related to our documentation guidelines. Could you please check if I didn't miss anything while doing so? Thank you for your patience, we appreciate it very much!
I also made a few comments and suggestions in my review. Please take a look at it and let me know if you have any questions. Thanks! 🙂

afma-odoo
afma-odoo reviewed Mar 6, 2025
View reviewed changes
@XIDO-odoo XIDO-odoo force-pushed the 18.0-Localization-NZ-XIDO branch from 81c7492 to 6b95464 Compare April 1, 2025 07:22
@XIDO-odoo XIDO-odoo force-pushed the 18.0-Localization-NZ-XIDO branch 3 times, most recently from 9fb6fbb to f464b7b Compare April 10, 2025 09:03
@XIDO-odoo
Copy link
Contributor Author

@afma-odoo Hello Afma, thank you for the long waiting. I made the revisions based on your feedback, could you please help check it again? Thank you!

afma-odoo
afma-odoo requested changes Apr 15, 2025
View reviewed changes
Copy link
Contributor
@afma-odoo afma-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @XIDO-odoo, thank you for the update ☺️
I added a few comments and suggestions in my review.
Some are related to the updates we made to our new loc doc template we are testing. Thank you for your help on this!
Feel free to let me know if you have any questions. Thanks!

Regarding the "Employment Hero Integration" section, I think the existing version (the one online) should be kept, as it references the existing Employment Hero Payroll documentation, and there's no specific information to add for New Zealand.

For your information, the "Payroll" sections previously documented in the Fiscal localizations pages will be moved to the new Payroll localizations directory and the Employment Hero Payroll documentation, too. Once done, we'll add a seealso at the top of the NZ fiscal localization doc, linking to the NZ payroll doc.

Thank you!

@XIDO-odoo XIDO-odoo force-pushed the 18.0-Localization-NZ-XIDO branch from f464b7b to f0d53ad Compare April 16, 2025 08:44
@XIDO-odoo
Copy link
Contributor Author

Hello @afma-odoo , thank you for the feedback.

I have revised the documentation based on your feedback, could you please have a double check?

For the "Employment Hero Integration" section and "Payroll" section, could you please tell me what I should do? Or should I just keep it as the current version?

Thank you!

afma-odoo
afma-odoo requested changes Apr 16, 2025
View reviewed changes
Copy link
Contributor
@afma-odoo afm 8000 a-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @XIDO-odoo!
Thank you for reviewing and helping us update your document with our recent loc-doc template change.
I just have two suggestions, with the one regarding the Employment Hero integration.
Does it suit you this way?
Let me know if you have any questions.
Thanks! 🙂

content/applications/finance/fiscal_localizations/new_zealand.rst Outdated
- :doc:`../accounting/get_started/chart_of_accounts`: a predefined structure tailored to New
Zealand accounting standards
- :doc:`../accounting/taxes/fiscal_positions`: automated tax adjustments based on customer or
supploer registration status
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
supploer registration status
supplier registration status

@XIDO-odoo XIDO-odoo force-pushed the 18.0-Localization-NZ-XIDO branch from f0d53ad to 2164d21 Compare April 16, 2025 10:40
@XIDO-odoo
Copy link
Contributor Author

Hello @afma-odoo , thank you for the quick support and explanation.

I think this works for me, the client can find out the necessary information from the Link.
I have just revised it based on your feedback, could you please have a double check?

And I'm also looking forward to see the "seealso" when the new documentations are ready!

Thank you~

afma-odoo
afma-odoo approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor
@afma-odoo afma-odoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @XIDO-odoo, the update looks great! I'll go ahead and approve it.
There's just a minor typo on line 43. Also, can you just make sure to delete the unnecessary image files. Thanks ☺️
I'll add the be-doc-review for the next step when it's done ;)

Thank you for updating the page!

@afma-odoo afma-odoo requested review from a team and removed request for a team April 17, 2025 07:52
@XIDO-odoo XIDO-odoo force-pushed the 18.0-Localization-NZ-XIDO branch from 2164d21 to 0def0a7 Compare April 22, 2025 04:03
@XIDO-odoo
Copy link
Contributor Author

Hello @afma-odoo , sorry for the late reply. (I'm just back from the Easter holiday)

Please check my updates: I have revised the typo and deleted the images.

If there are any other points that I need to do, please just let me know~

Thank you a lot!

afma-odoo
afma-odoo approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor
@afma-odoo afma-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @XIDO-odoo, hope you had a great Easter holiday ;)
I approved it and added be-doc for the next step.
Thank you for this update ☺️

@afma-odoo afma-odoo requested a review from a team April 22, 2025 06:55
xpl-odoo
xpl-odoo requested changes Apr 30, 2025
View reviewed changes
Copy link
Contributor
@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, we are almost there! :)
cc: @afma-odoo

@XIDO-odoo XIDO-odoo force-pushed the 18.0-Localization-NZ-XIDO branch from 0def0a7 to fd352bd Compare May 7, 2025 08:18
@XIDO-odoo
Copy link
Contributor Author

Hello @xpl-odoo , I have just finished the revisions, could you please have a check?
cc: @afma-odoo

Thank you!

@XIDO-odoo XIDO-odoo requested a review from xpl-odoo May 12, 2025 01:07
@XIDO-odoo XIDO-odoo requested a review from afma-odoo May 12, 2025 01:07
afma-odoo
afma-odoo approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor
@afma-odoo afma-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @XIDO-odoo for the update! Significant major update of this page :)
I approve it, so only @xpl-odoo's approval is needed.
Thank you ☺️

@xpl-odoo xpl-odoo force-pushed the 18.0-Localization-NZ-XIDO branch from fd352bd to 0ca5da4 Compare May 12, 2025 08:57
xpl-odoo
xpl-odoo approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor
@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. BCC5

Hello @XIDO-odoo !

I force-pushed some minor corrections; thanks for addressing all my comments/

@robodoo r+

@robodoo robodoo closed this in 0d6acab May 12, 2025
@fw-bot fw-bot mentioned this pull request May 12, 2025
Closed
This was referenced May 12, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpl-odoo xpl-odoo xpl-odoo approved these changes

@afma-odoo afma-odoo afma-odoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XIDO-odoo @robodoo @xpl-odoo @afma-odoo
0