Support for git repos as submodules#96
Merged
3rd-Eden merged 1 commit intoobserving:masterfrom May 5, 2017
faazshift:master
Merged
Support for git repos as submodules#963rd-Eden merged 1 commit intoobserving:masterfrom faazshift:master
3rd-Eden merged 1 commit intoobserving:masterfrom
faazshift:master
Conversation
Contributor
Author
|
Didn't look through the other PRs before doing this, but I see there were other abandoned attempts at submodule support. |
Contributor
Author
|
To follow-up on this, my change has now been tested across several platforms by several within my organization, and seems to work exactly as expected in all cases so far. |
|
LGTM 👍 |
Member
|
@faazshift The other PR's were not merged because of cross platform issues. |
imlucas
added a commit
to mongodb-js/pre-commit
that referenced
this pull request
Jan 15, 2019
This reverts commit 5eb7b9b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a git repo is setup as a submodule of another repo,
.gitis a file (rather than a directory) containing the path to the submodule's git directory within the parent repos.gitdirectory. This PR just adds the ability, if.gitis a file, to resolve the actual git directory and install/uninstall to the right location.