8000 Update dep to remove warn about cross-spaw by luanmuniz · Pull Request #76 · observing/pre-commit · GitHub
[go: up one dir, main page]
Skip to content

Update dep to remove warn about cross-spaw#76

Merged
3rd-Eden merged 2 commits intoobserving:masterfrom
luanmuniz:master
Jul 25, 2016
Merged

Update dep to remove warn about cross-spaw#76
3rd-Eden merged 2 commits intoobserving:masterfrom
luanmuniz:master

Conversation

@luanmuniz
Copy link
Contributor
@luanmuniz luanmuniz commented Jul 20, 2016

With this the following warn is fixed

npm WARN deprecated cross-spawn-async@2.2.4: cross-spawn no longer requires a build toolchain, use it instead!

@coveralls
Copy link
coveralls commented Jul 20, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 95.413% when pulling 33f0273 on luanmuniz:master into fec48cb on observing:master.

@3rd-Eden
Copy link
Member
3rd-Eden commented Jul 20, 2016

Error: In order to use spawnSync on node 0.10 or older, you must install spawn-sync

So it needs to have the spawn-sync module installed as well in order to not break backwards compatibility.

@luanmuniz
Copy link
Contributor Author
luanmuniz commented Jul 21, 2016

Is there any interest in doing this after the TLS for 0.10 and 0.12 ends?

@3rd-Eden
Copy link
Member
3rd-Eden commented Jul 21, 2016

Well all that is needed is to add spawn-sync to the dependencies and it should just pass the tests again.

@coveralls
Copy link
coveralls commented Jul 22, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 95.413% when pulling 58a4511 on luanmuniz:master into fec48cb on observing:master.

@luanmuniz
Copy link
Contributor Author
luanmuniz commented Jul 22, 2016

@3rd-Eden You are right, sorry. i was reading the name of this module and thinking on another. Just added the dependence.

@coveralls
Copy link
coveralls commented Jul 22, 2016

Coverage Status

Coverage remained the same at 95.413% when pulling 69e8b0e on luanmuniz:master into fec48cb on observing:master.

1 similar comment
@coveralls
Copy link
coveralls commented Jul 22, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 95.413% when pulling 69e8b0e on luanmuniz:master into fec48cb on observing:master.

@3rd-Eden 3rd-Eden merged commit 7154dee into observing:master Jul 25, 2016
@3rd-Eden
Copy link
Member
3rd-Eden commented Jul 25, 2016

Thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luanmuniz @coveralls @3rd-Eden
0