8000 158 Generate Nullable items in arrays by wjase · Pull Request #490 · oapi-codegen/oapi-codegen · GitHub
[go: up one dir, main page]
Skip to content

158 Generate Nullable items in arrays #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wjase wants to merge 5 commits into
base: main
Choose a base branch
from
Open

158 Generate Nullable items in arrays #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c32938
Merged makefile
wjase Nov 19, 2021
c8c88a2
158 - Generate Nullable array items
wjase Nov 26, 2021
f6f041b
Merge branch 'deepmap:master' into master
wjase Mar 12, 2022
0302661
Update Schema and echo server to support default values
wjase Mar 13, 2022
0a13122
Updates petstore get endpoint to include a default param. Re-ran gene…
wjase Mar 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile
8000 View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,8 @@ test:
tidy:
@echo "tidy..."
go mod tidy

build :
go build ./...

all: tidy build generate test
56 changes: 28 additions & 28 deletions examples/petstore-expanded/chi/api/petstore.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

68 changes: 38 additions & 30 deletions examples/petstore-expanded/echo/api/petstore-server.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions examples/petstore-expanded/petstore-expanded.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ paths:
schema:
type: integer
format: int32
default: 100
responses:
'200':
description: pet response
Expand Down
7 changes: 5 additions & 2 deletions internal/test/components/components.gen.go
8000
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 15 additions & 9 deletions internal/test/parameters/parameters.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion internal/test/schemas/schemas.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions pkg/codegen/codegen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ func GenerateTypesForSchemas(t *template.Template, schemas map[string]*openapi3.
}
schemaRef := schemas[schemaName]

goSchema, err := GenerateGoSchema(schemaRef, []string{schemaName})
goSchema, err := GenerateGoSchema(schemaRef, []string{schemaName}, true)
if err != nil {
return nil, fmt.Errorf("error converting Schema %s to Go type: %w", schemaName, err)
}
Expand Down Expand Up @@ -440,7 +440,7 @@ func GenerateTypesForResponses(t *template.Template, responses openapi3.Response
response := responseOrRef.Value
jsonResponse, found := response.Content["application/json"]
if found {
goType, err := GenerateGoSchema(jsonResponse.Schema, []string{responseName})
goType, err := GenerateGoSchema(jsonResponse.Schema, []string{responseName}, false)
if err != nil {
return nil, fmt.Errorf("error generating Go type for schema in response %s: %w", responseName, err)
}
Expand Down Expand Up @@ -478,7 +478,7 @@ func GenerateTypesForRequestBodies(t *template.Template, bodies map[string]*open
response := bodyOrRef.Value
jsonBody, found := response.Content["application/json"]
if found {
goType, err := GenerateGoSchema(jsonBody.Schema, []string{bodyName})
goType, err := GenerateGoSchema(jsonBody.Schema, []string{bodyName}, true)
if err != nil {
return nil, fmt.Errorf("error generating Go type for schema in body %s: %w", bodyName, err)
}
Expand Down
Loading
0