feat: support for use-httprouter-in-std-http-server in compatibility-options to allow to use github.com/julienschmidt/httprouter #2189
+1,075
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…options to allow to use github.com/julienschmidt/httprouter
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
jamietanna
requested changes
Jan 26, 2026
Member
There was a problem hiding this comment.
Thanks for this - I'd say this should be under output-options instead, after which this looks reasonable
Can we also make sure the JSON Schema is updated?
…not in compatibility-options
Author
Thank you for output-options instead of compatibility. I updated JSON Schema (configuration-schema.json file) and I don't know about any other I should update.. I am probably missing something.. Please be more specific if it is this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for github.com/julienschmidt/httprouter in StdHttpServer
I’d like to ask you for review of PR of the feature to add support for github.com/julienschmidt/httprouter in StdHttpServer.
It is implemented in such way that if a new flag use-httprouter-in-std-http-server in CompatibilityOptions is set to true, the updated code is generated.
The tests and examples are included.
Let me know if the way I trigger is correct and suggest a better approach if any.
Thank you,
Roman