8000 Update enum generation to generate a map to validate enums. by AndreasAbdi · Pull Request #2181 · oapi-codegen/oapi-codegen · GitHub
[go: up one dir, main page]
Skip to content

Update enum generation to generate a map to validate enums. #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndreasAbdi wants to merge 1 commit into
base: main
Choose a base branch
from
+51 −0
< 8000 div class="pr-toolbar d-flex js-toggle-stuck js-observe-sticky-header-height" data-target="diff-layout.diffToolbar">
Open

Update enum generation to generate a map to validate enums. #2181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions examples/extensions/xenumnames/gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions pkg/codegen/codegen_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,16 @@ type GetTestByNameResponse struct {
assert.Contains(t, code, "type EnumTestEnumNames int")
assert.Contains(t, code, "Two EnumTestEnumNames = 2")
assert.Contains(t, code, "Double EnumTestEnumVarnames = 2")

// Check that enum validation maps are generated:
assert.Contains(t, code, "var EnumTestNumericsValues = map[EnumTestNumerics]struct{}")
assert.Contains(t, code, "var EnumTestEnumNamesValues = map[EnumTestEnumNames]struct{}")
assert.Contains(t, code, "var EnumTestEnumVarnamesValues = map[EnumTestEnumVarnames]struct{}")

// Check that IsValid() methods are generated for each enum:
assert.Contains(t, code, "func (s EnumTestNumerics) IsValid() bool {")
assert.Contains(t, code, "func (s EnumTestEnumNames) IsValid() bool {")
assert.Contains(t, code, "func (s EnumTestEnumVarnames) IsValid() bool {")
}

func TestExtPropGoTypeSkipOptionalPointer(t *testing.T) {
Expand Down
11 changes: 11 additions & 0 deletions pkg/codegen/templates/constants.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,15 @@ const (
{{$name}} {{$Enum.TypeName}} = {{$Enum.ValueWrapper}}{{$value}}{{$Enum.ValueWrapper -}}
{{end}}
)

var {{$Enum.TypeName}}Values = map[{{$Enum.TypeName}}]struct{}{
{{- range $name, $value := $Enum.GetValues}}
{{$name}}: {},
{{- end}}
}

func (s {{$Enum.TypeName}}) IsValid() bool {
_, ok := {{$Enum.TypeName}}Values[s]
return ok
}
{{end}}
Loading
0