8000 [readme] remove `avn` from readme by andrew-chang-dewitt · Pull Request #3469 · nvm-sh/nvm · GitHub
[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme] remove avn from readme #3469

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

andrew-chang-dewitt
Copy link
Contributor
@andrew-chang-dewitt andrew-chang-dewitt commented Nov 13, 2024

avn is archived (see repo) and should probably no longer be recommended by nvm.

`avn` is archived ([see repo](https://github.com/direnv/direnv)) and should probably no longer be recommended by nvm.

This also adds a solution using `direnv` and proposes a possible `.envrc` to use.
See [wbyoung/avn#109](wbyoung/avn#109 (comment)) for more suggested `.envrc` files.
Copy link
Member
@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a pretty big chunk of code to include. probably should be wrapped in a <details>, but either way i think it needs to be polished a bit, and made POSIX-compliant (ie, no bash-specific syntax)

@andrew-chang-dewitt
Copy link
Contributor Author
andrew-chang-dewitt commented Nov 13, 2024

this is a pretty big chunk of code to include. probably should be wrapped in a <details>, but either way i think it needs to be polished a bit, and made POSIX-compliant (ie, no bash-specific syntax)

Good point. I think it might actually be even better to limit this PR to avn no longer being maintained & remove the direnv recommendation. I might put it in a second PR and open it later after some testing.

@ljharb
Copy link
Member
ljharb commented Nov 13, 2024

That sounds like a great plan!

@andrew-chang-dewitt andrew-chang-dewitt changed the title docs: remove avn from readme & add a direnv based solution docs: remove avn from readme Nov 13, 2024
@andrew-chang-dewitt
Copy link
Contributor Author

Should have everything not about avn removed from this now.

@ljharb ljharb changed the title docs: remove avn from readme [readme] remove avn from readme Nov 15, 2024
@ljharb ljharb closed this Nov 15, 2024
@ljharb ljharb reopened this Nov 15, 2024
@ljharb ljharb closed this Nov 18, 2024
@ljharb ljharb reopened this Nov 18, 2024
@ljharb ljharb merged commit 287d535 into nvm-sh:master Feb 3, 2025
169 of 171 checks passed
ljharb added a commit that referenced this pull request Mar 11, 2025
New Stuff
 - `install.sh`: add `$ZDOTDIR` to zsh search (#3458)

Fixes
 - `reinstall-packages`: do not reinstall corepack (#3544)
 - avoid bash-specific syntax (#3499)
 - `install-latest-npm`: npm v11 is out
 - `nvm_install_latest_npm`: avoid unbound variable (#3447)
 - give a more helpful message when `lts` alias is mistakenly used (#3441)
 - `nvm ls`, `nvm alias`, `nvm install`: error when an LTS name is invalid
 - `nvm_normalize_lts`: error when an LTS name is not lowercase (#3417)

Documentation
 - [readme] update link
 - [readme] fix `--no-use` example (#3479)
 - [readme] update copyright notice (#3507)
 - [readme] note zsh-nvm's AUTO_USE option (#2670)
 - [readme] add note about reloading zshrc after editing (#3052)
 - [readme] Update shell profile file install notes (#2241)
 - [readme] add docker tips (#2318)
 - [readme] remove `avn` from readme (#3469)
 - [readme] fnm -> nvm.fish (#2541)

Refactors
 - prefer `case` over if/else chains
 - combine `sed -e` invocations/arguments

Tests
 - `nvm exec`/`nvm run`: add `--silent` tests (#1259)
 - [actions] release test needs git tags
 - migrate `installation_iojs` test suite to GitHub Actions (#3476)
 - Migrate slow test suite from Travis CI (#3470)
 - temporarily skip this failing travis test to unblock progress
 - [actions] TOC: use latest LTS node
 - `install.sh`: clean up `nvm_detect_profile` tests
 - `nvm_detect_profile`: refactor (#3467)
 - run urchin tests on pull requests (#3466)
 - update mocks
 - ensure that unit tests use only mocked LTS names
 - [actions] use `node/install` instead of `node/run`

Meta
 - disable blank issues
 - update issue template
 - add DCO (#3456)
 - Rename .github/ISSUE_TEMPLATE.md to .github/ISSUE_TEMPLATE/ISSUE_TEMPLATE.md (#3454)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0