8000 fix: enable `allowArbitraryExtensions` by default in generated tsconfig by Teages · Pull Request #34084 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

fix: enable allowArbitraryExtensions by default in generated tsconfig#34084

Merged
danielroe merged 3 commits intonuxt:mainfrom
Teages:feat/enable-allow-arbitrary-extensions
Jan 20, 2026
Merged

fix: enable allowArbitraryExtensions by default in generated tsconfig#34084
danielroe merged 3 commits intonuxt:mainfrom
Teages:feat/enable-allow-arbitrary-extensions

Conversation

@Teages
Copy link
Contributor
@Teages Teages commented Jan 15, 2026 •
edited
Loading

🔗 Linked issue

Resolve #34083

📚 Description

The PR enabled allowArbitraryExtensions by default in all generated TSConfig, include tsconfig.app.json, tsconfig.server.json, tsconfig.node.json, tsconfig.shared.json and the legacy tsconfig.json.

@Teages Teages requested a review from danielroe as a code owner January 15, 2026 09:15
@bolt-new-by-stackblitz
Copy link
bolt-new-by-stackblitz bot commented Jan 15, 2026

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pkg-pr-new
Copy link
pkg-pr-new bot commented Jan 15, 2026 •
edited
Loading

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@34084

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@34084

nuxt

npm i https://pkg.pr.new/nuxt@34084

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@34084

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@34084

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@34084

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@34084

commit: b580bdc

@coderabbitai
Copy link
Contributor
coderabbitai bot commented Jan 15, 2026 •
edited
Loading

Walkthrough

The changes set allowArbitraryExtensions: true in TypeScript compilerOptions in two places: the generated tsConfig from _generateTypes in packages/kit/src/template.ts, and the Nitro tsconfig in packages/nitro-server/src/index.ts by adding allowArbitraryExtensions: true under nitroConfig.typescript.tsConfig.compilerOptions. The kit change also wires the option through when constructing nodeTsConfig and sharedTsConfig via tsConfig.compilerOptions?.allowArbitraryExtensions.

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: enabling allowArbitraryExtensions by default in generated tsconfig files.
Linked Issues check ✅ Passed The PR directly addresses issue #34083 by enabling allowArbitraryExtensions in generated TypeScript configs, resolving the TSError when importing Vue components built with @nuxt/module-builder.
Out of Scope Changes check ✅ Passed All changes are scoped to enabling allowArbitraryExtensions in TypeScript configurations (kit and nitro-server), directly addressing the linked issue without introducing unrelated modifications.
Description check ✅ Passed The pull request description clearly relates to the changeset, describing the enablement of allowArbitraryExtensions across multiple generated TypeScript config files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
codspeed-hq bot commented Jan 15, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing Teages:feat/enable-allow-arbitrary-extensions (b580bdc) with main (8aaf9d5)1

Summary

✅ 10 untouched benchmarks

Footnotes

  1. No successful run was found on main (f2ef4d4) during the generation of this report, so 8aaf9d5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

danielroe
danielroe reviewed Jan 15, 2026
View reviewed changes
8000
danielroe
danielroe approved these changes Jan 20, 2026
View reviewed changes
Copy link
Member
@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@danielroe danielroe merged commit 0645678 into nuxt:main Jan 20, 2026
55 checks passed
@github-actions github-actions bot mentioned this pull request Jan 20, 2026
Merged
@Teages Teages deleted the feat/enable-allow-arbitrary-extensions branch January 20, 2026 05:34
danielroe pushed a commit that referenced this pull request Jan 21, 2026
@Teages @danielroe
fix(kit,nitro): enable allowArbitraryExtensions by default (#34084)
d46065e
@github-actions github-actions bot mentioned this pull request Jan 21, 2026
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jan 26, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

4.x bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TSError --allowArbitraryExtensions is not set when importing components built with @nuxt/module-builder

2 participants

@Teages @danielroe
0