fix(kit): normalize layer directory paths with trailing slashes to support dotted folder names by rywils · Pull Request #33858 · nuxt/nuxt

rywils · 2025-12-12T05:17:08Z

🔗 Linked issue

resolves #33855

🐞 Can't import variables from ordered layers in nuxt config #33855

Nuxt’s auto layer discovery strips the trailing slash from layers/* results.
When a layer folder contains a dot (e.g. 01.base), the resolver interprets it as a file extension instead of a directory and throws:

Cannot find module 'layers/01.base'

The change makes Nuxt always keep a trailing slash on auto-detected layer paths, so dotted folders are consistently handled as directories. Fairly simple, straight forward fix.

Cheers!

bolt-new-by-stackblitz · 2025-12-12T05:17:12Z

Run & review this pull request in StackBlitz Codeflow.

pkg-pr-new · 2025-12-12T05:20:15Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33858

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@33858

nuxt

npm i https://pkg.pr.new/nuxt@33858

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33858

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33858

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33858

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33858

commit: 21a5c0c

coderabbitai · 2025-12-12T05:20:43Z

Walkthrough

This pull request modifies the loader configuration in packages/kit/src/loader/config.ts to adjust trailing slash handling for local layers. The change replaces a single import from ufo with both withTrailingSlash and withoutTrailingSlash utilities. The normalisation of localLayers switches from removing trailing slashes to explicitly enforcing them via withTrailingSlash. Conversely, the construction of localRelativePaths now removes trailing slashes from localLayers using withoutTrailingSlash, reversing the previous path comparison logic. No public API signatures are a 8000 ffected.

Possibly related PRs

fix(kit,nuxt,schema): add trailing slash to some dir aliases #32755: Modifies the same trailing-slash normalisation in packages/kit/src/loader/config.ts using withTrailingSlash and withoutTrailingSlash utilities.
perf(kit,nuxt): don't resolve paths from local layers/modules #30650: Adjusts how local layer and module paths are normalised and compared through prefix-based matching with trailing-slash normalisation.
fix(kit): ensure local layers are prioritised alphabetically #33030: Modifies packages/kit/src/loader/config.ts to alter layer normalisation alongside changes to layer ordering logic.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: normalizing layer directory paths with trailing slashes to support dotted folder names, which directly matches the changeset's core objective.
Description check	✅ Passed	The pull request description clearly relates to the changeset, explaining the fix for layer directory path normalization with trailing slashes to support dotted folder names.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Tip

✨ Issue Enrichment is now available for GitHub issues!

CodeRabbit can now help you manage issues more effectively:

Duplicate Detection — Identify similar or duplicate issues
Related Issues & PRs — Find relevant issues and PR's from your repository
Suggested Assignees — Find the best person to work on the issue
Implementation Planning — Generate detailed coding plans for engineers and agents

Disable automatic issue enrichment

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codspeed-hq · 2025-12-12T05:28:11Z

CodSpeed Performance Report

Merging #33858 will improve performances by 12.17%

_{Comparing rywils:dotted-layer-directories (21a5c0c) with main (c1b3590)¹}

Summary

⚡ 1 improvement
✅ 9 untouched

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
⚡	`writeTypes in the basic-types fixture`	90.5 ms	80.7 ms	+12.17%

No successful run was found on main (672880b) during the generation of this report, so c1b3590 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

jd-solanki · 2025-12-12T06:50:51Z

I'm not sure about tests but is it possible to have test case for numbered layers directories?

danielroe

nice! thank you ❤️

jd-solanki · 2025-12-12T12:29:44Z

Hey @danielroe

Is it possible to change order of layers via extends so we don't have to rename directories when we want to add new layer which required to be placed between existing layers.

Benefits:

When using template repo it doesn't break pull updates
When checking repo history it doesn't confuse

I would love to have this feature, Should I raise a feature request for this?

danielroe · 2025-12-12T14:08:17Z

unfortunately that's not possible with local layers.

if you want that, move them out of the layers directory and register them with extends instead. we can't mix + match.

fix: normalize layer directory paths with trailing slashes

21a5c0c

rywils requested a review from danielroe as a code owner December 12, 2025 05:17

github-actions bot added 4.x bug labels Dec 12, 2025

danielroe approved these changes Dec 12, 2025

View reviewed changes

danielroe merged commit 7d50229 into nuxt:main Dec 12, 2025
57 checks passed

github-actions bot mentioned this pull request Dec 12, 2025

v4.2.3 #33843

Closed

rywils deleted the dotted-layer-directories branch December 13, 2025 23:36

danielroe pushed a commit that referenced this pull request Dec 15, 2025

fix(kit): normalize local layer paths with trailing slashes (#33858)

2a011e3

This was referenced Dec 15, 2025

v3.20.3 #33890

Closed

v4.3.0 #33894

Merged

jd-solanki mentioned this pull request Jan 2, 2026

✨ Allow re-ordering local layers via nuxt.config.ts #34009

Open

4 tasks

coderabbitai bot mentioned this pull request Jan 4, 2026

Nuxt layer cannot resolve custom CSS asset (~/assets/main.css) at runtime #34015

Closed

github-actions bot mentioned this pull request Jan 21, 2026

v3.21.0 #34129

Merged

rywils restored the dotted-layer-directories branch March 14, 2026 03:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(kit): normalize layer directory paths with trailing slashes to support dotted folder names#33858

fix(kit): normalize layer directory paths with trailing slashes to support dotted folder names#33858
danielroe merged 1 commit intonuxt:mainfrom
rywils:dotted-layer-directories

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Uh oh!

🔗 Linked issue

🐞 Can't import variables from ordered layers in nuxt config #33855

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Walkthrough

Possibly related PRs

Pre-merge checks and finishing touches

Uh oh!

CodSpeed Performance Report

Merging #33858 will improve performances by 12.17%

Summary

Benchmarks breakdown

Footnotes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants