8000 fix(nuxt): default `spaLoadingTemplate` to `false` by danielroe · Pull Request #22798 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

fix(nuxt): default spaLoadingTemplate to false #22798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2023
Merged

fix(nuxt): default spaLoadingTemplate to false #22798

merged 3 commits into from
Aug 25, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This is a behaviour change from v3.5 - we now default the Nuxt logo SPA loading template to false. Despite being beautiful, probably users would want to remove this before deploying their Nuxt sites. If you want to keep the previous behaviour, you can instead set spaLoadingTemplate to `true.

👉 Migration

export default defineNuxtConfig({
  ssr: false,
  spaLoadingTemplate: true
})

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Aug 24, 2023
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pi0
Copy link
Member
pi0 commented Aug 24, 2023

Disabling by default is probably better than current state 👍 However it might affect users experience when there is a SPA error, they will only see a white screen (also when bundle is too big/connection is slow) We might also differ to later but any possible fallback to indicate long loadings and errors..

@DamianGlowala DamianGlowala changed the title fix(nuxt): default spaLoadingTemplate to `false fix(nuxt): default spaLoadingTemplate to false Aug 25, 2023
@danielroe danielroe merged commit a352d59 into main Aug 25, 2023
@danielroe danielroe deleted the fix/template branch August 25, 2023 12:26
@github-actions github-actions bot mentioned this pull request Aug 25, 2023
Merged
danielroe added a commit that referenced this pull request Aug 25, 2023
@danielroe
fix(nuxt): default spaLoadingTemplate to false (#22798)
f48c536
This was referenced Sep 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielroe danielroe

Labels
3.x bug 🔨 p3-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0
0