8000 fix(nuxt): add `exclude` paths to nitro `tsconfig.server.json` by huseeiin · Pull Request #22768 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

fix(nuxt): add exclude paths to nitro tsconfig.server.json #22768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 23, 2023
Merged

fix(nuxt): add exclude paths to nitro tsconfig.server.json #22768

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5143886
Update nitro.ts (Fix TS5055)
huseeiin Aug 23, 2023
7d82057
fix(nuxt): warn when ignoring duplicate island/server component (#22709)
huang-julien Aug 23, 2023
1d9eced
perf(nuxt): reduce multiple calls to `.toLowerCase()` (#22743)
djixadin Aug 23, 2023
06b44cc
chore(deps): update all non-major dependencies (main) (#22770)
renovate[bot] Aug 23, 2023
0779939
fix: add exclude to correct nested obj
danielroe Aug 23, 2023
02180ae
Merge remote-tracking branch 'origin/main' into xxxhussein/main
danielroe Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/nuxt/src/core/nitro.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ export async function initNitro (nuxt: Nuxt & { _nitro?: Nitro }) {
tsConfig: {
include: [
join(nuxt.options.buildDir, 'types/nitro-nuxt.d.ts')
],
exclude: [
...nuxt.options.modulesDir.map(m => relativeWithDot(nuxt.options.buildDir, m)),
Copy link
Member
@pi0 pi0 Aug 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Consider modulesDir can technically be normal directories with parent/sibling node_modules dir) as well. We might have filtered out the ones not ending with node_modules here for greater safety.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice idea. I've just copied across our current default in the nuxt tsconfig so if we filter it further we should update them in parallel.

// nitro generate output: https://github.com/nuxt/nuxt/blob/main/packages/nuxt/src/core/nitro.ts#L186
relativeWithDot(nuxt.options.buildDir, resolve(nuxt.options.rootDir, 'dist'))
]
}
},
Expand Down Expand Up @@ -403,3 +408,7 @@ export async function initNitro (nuxt: Nuxt & { _nitro?: Nitro }) {
nuxt.hook('build:done', () => waitUntilCompile)
}
}

function relativeWithDot (from: string, to: string) {
return relative(from, to).replace(/^([^.])/, './$1') || '.'
}
0