8000 test: refactor test suite and reduce `networkidle` dependency by danielroe · Pull Request #22596 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

test: refactor test suite and reduce networkidle dependency #22596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 12, 2023
Merged

test: refactor test suite and reduce networkidle dependency #22596

merged 6 commits into from
Aug 12, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This refactors test suite to reduce dependency on networkidle event (more is required here!) to reduce potential flakiness in CI.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Aug 11, 2023
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 12, 2023
View reviewed changes
test/hmr.test.ts
@@ -17,7 +17,7 @@
dev: true,
server: true,
browser: true,
setupTimeout: (isWindows ? 240 : 120) * 1000,
setupTimeout: (isWindows ? 360 : 120) * 1000,

Check warning

Code scanning / CodeQL

Useless conditional

This use of variable 'isWindows' always evaluates to false.
@danielroe danielroe merged commit e93195a into main Aug 12, 2023
@danielroe danielroe deleted the test/load-state branch August 12, 2023 07:18
@github-actions github-actions bot mentioned this pull request Aug 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielroe danielroe

Labels
3.x chore test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danielroe
0