8000 fix(nuxt): unsub from hooks when unmounting indicator by danielroe · Pull Request #22592 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

fix(nuxt): unsub from hooks when unmounting indicator #22592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix(nuxt): unsub from hooks when unmounting indicator #22592

merged 1 commit into from
Aug 11, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Spotted this unreported bug. If we ever remove loading indicator it can cause an error because we'll still be calling methods on the unmounted component.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Aug 11, 2023
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit 1a61cb2 into main Aug 11, 2023
@danielroe danielroe deleted the fix/unsub-hook branch August 11, 2023 12:15
@github-actions github-actions bot mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielroe danielroe

Labels
3.x bug 🔨 p3-minor pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danielroe
0