fix(nuxt): trigger immediate DOM update on page:finish
#22566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
page:finish
page:finishpage:finish
danielroe
reviewed
Aug 9, 2023
| } | ||
| head.hooks.hook('dom:beforeRender', (context) => { context.shouldRender = !pauseDOMUpdates }) | ||
| nuxtApp.hooks.hook('page:start', () => { pauseDOMUpdates = true }) | ||
| // wait for new page before unpausing dom updates (triggered after suspense resolved) | ||
| nuxtApp.hooks.hook('page:finish', unpauseDom) | ||
| nuxtApp.hooks.hook('page:finish', syncHead) |
There was a problem hiding this comment.
What do you think? Would it make sense to dispatch the event but not await it?
Suggested change
| nuxtApp.hooks.hook('page:finish', syncHead) | |
| nuxtApp.hooks.hook('page:finish', () => { syncHead() }) |
There was a problem hiding this comment.
Ideally we'd do this but then it doesn't solve the issues linked 🤔
There's an experimental flag we can enable that should make the initial SSR hydration 0ms to overcome this overhead.
The risk I see outside of that is if someone has a promise on one of the head tags that is extra slow to resolve it would slow the page transition. Although maybe that's useful for the title (as outlined in the issue)
danielroe
approved these changes
Aug 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#22334, #22560
❓ Type of change
📚 Description
When updating the DOM from head changes, we batch the changes, this reduces DOM thrashing. We use this batching when the page is finishing which is causing the linked issue.
However, we can just update the head immediately.
One issue with this solution though is the
page:finishis now delayed, on average this is ~10ms for a few DOM updates (if needed), so maybe worth considering if this change is worth it.📝 Checklist