8000 docs: add closing blocks for `ReadMore` components by curtgrimes · Pull Request #22541 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

docs: add closing blocks for ReadMore components #22541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2023
Merged

docs: add closing blocks for ReadMore components #22541

merged 1 commit into from
Aug 8, 2023

Conversation

curtgrimes
Copy link
Contributor

Fix Experimental Features page not loading completely due to ReadMore sections that were not closed.

🔗 Linked issue

#22540

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fix the ReadMore syntax on the Experimental Features page to match other uses of ReadMore like in this example on the State Management page.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@curtgrimes
docs: fix Experimental Features page not loading completely
d018369 
Fix Experimental Features page not loading completely due to ReadMore
sections that were not closed.
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxt-studio
Copy link
Contributor
nuxt-studio bot commented Aug 8, 2023

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview d018369

@curtgrimes
Copy link
Contributor Author

I was unable to reproduce this issue locally, but the ReadMore syntax on this particular page did not match other uses, so for now I am thinking that was causing the issue with the page not loading completely.

I cloned the Nuxt repo, ran pnpm install, pnpm build, and pnpm docs:dev. The docs load locally, but the issue is not present, and the docs also look pretty different in style compared to what is live at https://nuxt.com/docs at the moment. I am not sure if I missed a step (I could not find clear documentation on running the docs site locally) or if there are larger changes in flux with the docs (I did see #22469).

local docs dev

Screenshot-Experimental Features · Nuxt Advanced-2023-08-08-10-00-30

nuxt.com/docs

Screenshot-Experimental Features · Nuxt Advanced-2023-08-08-10-00-22

@danielroe danielroe changed the title docs: fix Experimental Features page not loading completely docs: add closing blocks for ReadMore components Aug 8, 2023
@danielroe danielroe merged commit 0141975 into nuxt:main Aug 8, 2023
@github-actions github-actions bot mentioned this pull request Aug 8, 2023
Merged
@danielroe
Copy link
Member

Thank you for spotting and fixing this! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAlexLichter TheAlexLichter TheAlexLichter approved these changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curtgrimes @danielroe @TheAlexLichter
0