8000 feat(nuxt): make `app.rootId` optional by DamianGlowala · Pull Request #22528 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

feat(nuxt): make app.rootId optional #22528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 12, 2023
Merged

feat(nuxt): make app.rootId optional #22528

merged 7 commits into from
Aug 12, 2023

Conversation

DamianGlowala
Copy link
Member
@DamianGlowala DamianGlowala commented Aug 7, 2023 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR allows setting app.rootId to false, which mounts the Vue app to the <body>'s direct descendant app.rootTag without the ID (should users didn't have a need to inject one).

I am not sure whether this has any negative implications, but at least it's an idea worth considering.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@DamianGlowala DamianGlowala changed the title feat: make app.rootId optional feat(nuxt): make app.rootId optional Aug 7, 2023
danielroe
danielroe reviewed Aug 7, 2023
View reviewed changes
@DamianGlowala DamianGlowala requested a review from danielroe August 9, 2023 08:00
@danielroe danielroe merged commit b5b2b47 into main Aug 12, 2023
@danielroe danielroe deleted the feat/optional-root-id branch August 12, 2023 07:19
@github-actions github-actions bot mentioned this pull request Aug 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DamianGlowala @danielroe
0