8000 fix(nuxt): enable hmr of `app.config.ts` files by danielroe · Pull Request #22494 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

fix(nuxt): enable hmr of app.config.ts files #22494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2023
Merged

fix(nuxt): enable hmr of app.config.ts files #22494

merged 2 commits into from
Aug 7, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently when we have an update to app.config.ts it can cause a hard reload of entire app. I am working with @benjamincanac to figure out the exact scenario, but it's reproducible with nuxtlabs/ui. This fixes it but I'm reluctant to merge until I have a minimal reproduction.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 August 4, 2023 12:17
@danielroe danielroe self-assigned this Aug 4, 2023
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe
Copy link
Member Author

/trigger release

@github-actions
Copy link
Contributor
github-actions bot commented Aug 4, 2023

🚀 Release triggered! You can now install nuxt@npm:nuxt3@pr-22494

@danielroe danielroe marked this pull request as ready for review August 7, 2023 22:13
@danielroe danielroe enabled auto-merge (squash) August 7, 2023 22:21
@danielroe danielroe merged commit 9c5b9b7 into main Aug 7, 2023
@danielroe danielroe deleted the fix/app-config-hmr branch August 7, 2023 22:23
@github-actions github-actions bot mentioned this pull request Aug 7, 2023
Merged
@danielroe danielroe mentioned this pull request Aug 18, 2023
Merged
11 tasks
@benjamincanac benjamincanac mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
3.x bug 🔨 p3-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0
0