feat(nuxt): resolve unresolved paths within node_modules
#22478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pi0
reviewed
Aug 4, 2023
pi0
reviewed
Aug 4, 2023
pi0
reviewed
Aug 4, 2023
Co-authored-by: pooya parsa <pyapar@gmail.com>
danielroe
commented
Aug 4, 2023
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Merged
8 tasks
sxzz
reviewed
Oct 6, 2023
| // TODO: respect nitro runtime conditions | ||
| conditions: options.ssr ? ['node', 'import', 'require'] : ['import', 'require'] | ||
| }).catch(() => { | ||
| console.log('[nuxt] Could not resolve id', id, importer) |
There was a problem hiding this comment.
Some plugins like Vue Macros will try to resolve multiple times, until successfully. In nuxt, it will warn and could disturb on userland.
Can we change it from log to debug level?
There was a problem hiding this comment.
That makes sense to me.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#14146
❓ Type of change
📚 Description
This adds a resolve step to resolve paths deeply within
node_moduleswhich cannot otherwise be resolved.In my testing, this enables use with vite and without shamefully-hoist, as long as
vueandvue-routerare explicitly installed (as they are in vite'soptimizeDeps.include).📝 Checklist