8000 fix(nuxt): print name of missing island component by MiniDigger · Pull Request #22440 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

fix(nuxt): print name of missing island component #22440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix(nuxt): print name of missing island component #22440

merged 1 commit into from
Aug 2, 2023

Conversation

MiniDigger
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

noticed this while experimenting with component islands, the error message would always contain undefined, I assume the name was intended to be displayed here instead.

before: http://localhost:3000/__nuxt_error/?url=/__nuxt_island_dum_dum/?name=dum&statusCode=404&statusMessage=Island+component+not+found:+undefined&message=Island+component+not+found:+undefined&stack
after: http://localhost:3000/__nuxt_error/?url=/__nuxt_island_dum_dum/?name=dum&statusCode=404&statusMessage=Island+component+not+found:+dum&message=Island+component+not+found:+dum&stack

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title fix: error message for missing island component is always undefined fix(nuxt): print name of missing island component Aug 2, 2023
@danielroe danielroe merged commit 7489b7d into nuxt:main Aug 2, 2023
@github-actions github-actions bot mentioned this pull request Aug 2, 2023
Merged
@MiniDigger MiniDigger deleted the patch-1 branch August 2, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiniDigger @danielroe
0