8000 fix(nuxi): only strip extensions from files by wattanx · Pull Request #22399 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

fix(nuxi): only strip extensions from files #22399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2023
Merged

fix(nuxi): only strip extensions from files #22399

merged 2 commits into from
Jul 30, 2023

Conversation

wattanx
Copy link
Collaborator
@wattanx wattanx commented Jul 30, 2023

🔗 Linked issue

Fixes: #22344

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently trying to remove the extension even if it is not a file.
Fixed to remove the extension only if the file.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

danielroe
danielroe approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member
@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@danielroe danielroe changed the title fix(nuxi): only strip from files fix(nuxi): only strip extensions from files Jul 30, 2023
@danielroe danielroe merged commit 8166fb2 into nuxt:main Jul 30, 2023
@github-actions github-actions bot mentioned this pull request Jul 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The inclusion of a dot in the filename does not result in the expected output of paths.
2 participants
@wattanx @danielroe
0